Issue 1010613002: Allow creating background tabs in response to ctrl+tapping events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1010613002: Allow creating background tabs in response to ctrl+tapping events (Closed)

Created:
5 years, 9 months ago by Miyoung Shin(g)

Modified:
5 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Allow creating background tabs in response to ctrl+tapping events The problem is to work the foreground tab when tapping of gesture with Ctrl key. The click event is simulated on tapping of gesture, and it should work to open the tab on the background like the left button of the mouse with Ctrl key. This patch is to allow opening the background tab on tapping of gesture. BUG=464718 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192003

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	Source/core/loader/FrameLoader.cpp	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	Source/web/FrameLoaderClientImpl.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010613002/1

5 years, 9 months ago (2015-03-17 10:47:47 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-17 12:12:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192003

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages