[Extension API Extern Generation] Fix comment indentation

[Extension API Extern Generation] Fix comment indentation

For extern comments, line wrapping sometimes has indentation. For instance:
/**
 * @param {FooBar} This is some foobar
 *     that has the comment wrapped.
 */
We should support this.  Add an optional parameter to the Code Comment method
to allow for comment indentation.

BUG=461039
Committed: https://crrev.com/8ea16e11973638ad0aafa9681997fade9305bcff
Cr-Commit-Position: refs/heads/master@{#322504}

[Devlin, 2015-03-26 22:36:54]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org

[Devlin, 2015-03-26 22:36:55]

Annnnd... here's extern comment wrapping.

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/code.py (right):

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/code.py:101: line = comment[0:max_len]
Technically, this means treats the max length as 1 less than the comment line
length (i.e., 79 instead of 80).  Is that intentional?  It's even part of the
test case...

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/code_test.py (right):

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/code_test.py:137: 'in longness, that is, to use\n'
Here, on an 80 char line, 'another' fits on the previous line.

[Dan Beam, 2015-03-26 22:41:49]

lgtm

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/code.py (right):

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/code.py:101: line = comment[0:max_len]
On 2015/03/26 22:36:54, Devlin wrote:
> Technically, this means treats the max length as 1 less than the comment line
> length (i.e., 79 instead of 80).  Is that intentional?  It's even part of the
> test case...

i think 80 is fine...?

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/code_test.py (right):

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/code_test.py:137: 'in longness, that is, to use\n'
On 2015/03/26 22:36:54, Devlin wrote:
> Here, on an 80 char line, 'another' fits on the previous line.

hmmm, I'd just update. seems like an off-by-one error

[Devlin, 2015-03-26 23:11:21]

Patchset #2 (id:20001) has been deleted

[Devlin, 2015-03-26 23:13:08]

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/code.py (right):

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/code.py:101: line = comment[0:max_len]
On 2015/03/26 22:41:48, Dan Beam wrote:
> On 2015/03/26 22:36:54, Devlin wrote:
> > Technically, this means treats the max length as 1 less than the comment
line
> > length (i.e., 79 instead of 80).  Is that intentional?  It's even part of
the
> > test case...
> 
> i think 80 is fine...?

Thought so, but figured good to double check.

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/code_test.py (right):

https://codereview.chromium.org/1010603007/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/code_test.py:137: 'in longness, that is, to use\n'
On 2015/03/26 22:41:49, Dan Beam wrote:
> On 2015/03/26 22:36:54, Devlin wrote:
> > Here, on an 80 char line, 'another' fits on the previous line.
> 
> hmmm, I'd just update. seems like an off-by-one error

Done.

[Devlin, 2015-03-26 23:13:10]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-03-26 23:13:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1010603007/#ps40001
(title: "True 80 char limit")

[commit-bot: I haz the power, 2015-03-26 23:13:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010603007/40001

[commit-bot: I haz the power, 2015-03-27 00:13:22]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-27 00:14:29]

Patchset 2 (id:??) landed as
https://crrev.com/8ea16e11973638ad0aafa9681997fade9305bcff
Cr-Commit-Position: refs/heads/master@{#322504}