Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/browser/ui/panels/docked_panel_strip.cc

Issue 10106008: Change Panel titlebars to activate the panel on click (rather than minimize). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win compile Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/docked_panel_strip.cc
diff --git a/chrome/browser/ui/panels/docked_panel_strip.cc b/chrome/browser/ui/panels/docked_panel_strip.cc
index 99978374b831b7d83c8b8331e1049420c026ee52..35edf43b7933de68408f15c890b86249afa31012 100644
--- a/chrome/browser/ui/panels/docked_panel_strip.cc
+++ b/chrome/browser/ui/panels/docked_panel_strip.cc
@@ -473,11 +473,13 @@ void DockedPanelStrip::OnPanelAttentionStateChanged(Panel* panel) {
void DockedPanelStrip::OnPanelTitlebarClicked(Panel* panel,
panel::ClickModifier modifier) {
DCHECK_EQ(this, panel->panel_strip());
+ if (!IsPanelMinimized(panel))
+ return;
+
if (modifier == panel::APPLY_TO_ALL)
ToggleMinimizeAll(panel);
-
- // TODO(jennb): Move all other titlebar click handling here.
- // (http://crbug.com/118431)
+ else
+ RestorePanel(panel);
}
void DockedPanelStrip::ActivatePanel(Panel* panel) {
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698