chrome/browser/ui/panels/detached_panel_strip.cc - Issue 10106008: Change Panel titlebars to activate the panel on click (rather than minimize).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/detached_panel_strip.cc

Issue 10106008: Change Panel titlebars to activate the panel on click (rather than minimize). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: GTK changes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/panels/detached_panel_strip.cc

diff --git a/chrome/browser/ui/panels/detached_panel_strip.cc b/chrome/browser/ui/panels/detached_panel_strip.cc

index 72fccf050888fcab293cfbf08dc7d2b56c6cd392..a74a86c13628eca1f0a835419a0e7b7e91abb3b0 100644

--- a/chrome/browser/ui/panels/detached_panel_strip.cc

+++ b/chrome/browser/ui/panels/detached_panel_strip.cc

@@ -65,7 +65,7 @@ void DetachedPanelStrip::OnPanelAttentionStateChanged(Panel* panel) {

void DetachedPanelStrip::OnPanelTitlebarClicked(Panel* panel,

panel::ClickModifier modifier) {

DCHECK_EQ(this, panel->panel_strip());

- // Click on detached panel titlebars does not do anything.

+ panel->Activate();

Dmitry Titov 2012/04/18 01:49:46 See the comment in the same method of the DockStri

jennb 2012/04/24 18:47:14 Reverted.

}

void DetachedPanelStrip::ResizePanelWindow(

« no previous file with comments | « no previous file | chrome/browser/ui/panels/docked_panel_strip.cc » ('j') | chrome/browser/ui/panels/docked_panel_strip.cc » ('J')