Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1010493007: Make the status bar translucent (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the status bar translucent This CL lets Sky apps draw behind the Android status bar, better matching the material design spec. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9af5e36b76ea9487b42fe4df94ba2fc8a510fd62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M sky/framework/components/drawer_header.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/framework/components/toolbar.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/framework/theme/view-configuration.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/org/domokit/sky/shell/SkyActivity.java View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-16 18:12:31 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-16 18:13:48 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-16 18:14:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9af5e36b76ea9487b42fe4df94ba2fc8a510fd62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698