Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1010473002: Revert of Move Extension ScriptContext creation into ScriptContextSet. (Closed)

Created:
5 years, 9 months ago by not at google - send to devlin
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move Extension ScriptContext creation into ScriptContextSet. (patchset #3 id:40001 of https://codereview.chromium.org/995283004/) Reason for revert: Broke ScriptContextTest.GinRunnerLifetime. Original issue's description: > Move Extension ScriptContext creation into ScriptContextSet. > > Previously extensions::Dispatcher was responsible for creating ScriptContexts > then Adding them to its ScriptContextSet. Now, ScriptContextSet creates them > itself. This prepares the Extension system for later changing to lazily or > asynchronously creating ScriptContexts. > > BUG=466373 > R=rockot@chromium.org > > Committed: https://crrev.com/75605c7fca774b95984ba67f70ba86bb5750c0f6 > Cr-Commit-Position: refs/heads/master@{#320602} TBR=rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466373 Committed: https://crrev.com/8ee8ee9e645596d0eabda36b30e3b99c24920940 Cr-Commit-Position: refs/heads/master@{#320626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -318 lines) Patch
M chrome/renderer/extensions/webstore_bindings.h View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M extensions/renderer/dispatcher.h View 7 chunks +21 lines, -5 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 16 chunks +157 lines, -26 lines 0 comments Download
M extensions/renderer/document_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/request_sender.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/script_context.h View 5 chunks +5 lines, -23 lines 0 comments Download
M extensions/renderer/script_context.cc View 3 chunks +1 line, -20 lines 0 comments Download
M extensions/renderer/script_context_set.h View 4 chunks +20 lines, -64 lines 0 comments Download
M extensions/renderer/script_context_set.cc View 4 chunks +49 lines, -136 lines 0 comments Download
M extensions/renderer/script_context_set_unittest.cc View 1 chunk +33 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
Created Revert of Move Extension ScriptContext creation into ScriptContextSet.
5 years, 9 months ago (2015-03-14 00:50:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010473002/1
5 years, 9 months ago (2015-03-14 00:51:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-14 00:52:36 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 00:53:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ee8ee9e645596d0eabda36b30e3b99c24920940
Cr-Commit-Position: refs/heads/master@{#320626}

Powered by Google App Engine
This is Rietveld 408576698