Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1010433008: remove reference to deprecated kHasFilter16 (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove reference to deprecated kHasFilter16 BUG= TBR=fmalita@chromium.org Committed: https://crrev.com/251f81e8ac238baef06f243e931285868e8e3191 Cr-Commit-Position: refs/heads/master@{#321992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M skia/ext/benchmarking_canvas.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010433008/1
5 years, 9 months ago (2015-03-24 12:30:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 13:32:31 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/251f81e8ac238baef06f243e931285868e8e3191 Cr-Commit-Position: refs/heads/master@{#321992}
5 years, 9 months ago (2015-03-24 13:33:21 UTC) #5
Stephen Chennney
Breaks Chrome build, at least on Windows. What should we use instead? [896/8861] CXX obj\skia\ext\skia.benchmarking_canvas.obj ...
5 years, 9 months ago (2015-03-26 17:39:42 UTC) #7
Stephen Chennney
On 2015/03/26 17:39:42, Stephen Chenney wrote: > Breaks Chrome build, at least on Windows. What ...
5 years, 9 months ago (2015-03-26 17:40:11 UTC) #8
Stephen Chennney
5 years, 9 months ago (2015-03-26 17:55:05 UTC) #9
Message was sent while issue was closed.
Dammit. Windows apparently doesn't update files correctly, or some git problem.
I just don't know.

Powered by Google App Engine
This is Rietveld 408576698