Source/core/dom/ScriptLoader.h - Issue 1010433007: Fire error event when script integrity check fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ScriptLoader.h

Issue 1010433007: Fire error event when script integrity check fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/subresourceIntegrity/subresource-integrity-script-no-cors-no-xorigin-with-creds.html ('k') | Source/core/dom/ScriptLoader.cpp » ('j') | Source/core/dom/ScriptLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ScriptLoader.h

diff --git a/Source/core/dom/ScriptLoader.h b/Source/core/dom/ScriptLoader.h

index 7c2ce1b03107675ca6d4abc01b4f1f041438ad5d..4667e056714ad3c976e71b10203f8499ecc7354d 100644

--- a/Source/core/dom/ScriptLoader.h

+++ b/Source/core/dom/ScriptLoader.h

@@ -53,7 +53,9 @@ public:

String scriptCharset() const { return m_characterEncoding; }

String scriptContent() const;

- void executeScript(const ScriptSourceCode&, double* compilationFinishTime = 0);

+ // Returns false if and only if there was a fatal execution error, namely

Mike West 2015/03/23 19:49:43 Hrm. Perhaps "if execution was blocked"? What do w

jww 2015/03/23 21:56:52 Done. See responses in ScriptLoader.cpp for more d

+ // an integrity check failure.

+ bool executeScript(const ScriptSourceCode&, double* compilationFinishTime = 0);

virtual void execute();

// XML parser calls these