Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1010433003: Bump picture version for uniqueID-less SkImageFilter. (Closed)

Created:
5 years, 9 months ago by Stephen White
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Bump picture version for uniqueID-less SkImageFilter. Remove writing of the uniqueID, and put reading behind a version check. BUG=skia:3559 Committed: https://skia.googlesource.com/skia/+/4a22a433bfb972dcd96f76e3d3b0613c26d8fc86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M include/core/SkPicture.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Stephen White
PTAL
5 years, 9 months ago (2015-03-18 19:45:56 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-03-18 19:49:18 UTC) #3
robertphillips
lgtm
5 years, 9 months ago (2015-03-18 19:56:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010433003/1
5 years, 9 months ago (2015-03-18 19:57:33 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 20:14:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4a22a433bfb972dcd96f76e3d3b0613c26d8fc86

Powered by Google App Engine
This is Rietveld 408576698