Added support for multiple urls in the component updater.

chrome/browser/component_updater/test/update_response_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_vector.h"
 #include "chrome/browser/component_updater/update_response.h"
 #include "libxml/globals.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace component_updater {
@@ skipping 48 matching lines @@
 "         <package name='3' />"
 "         <package name='4' size='-a'/>"
 "         <package name='5' size='-123467890123456789'/>"
 "         <package name='6' size='123467890123456789'/>"
 "       </packages>"
 "     </manifest>"
 "   </updatecheck>"
 " </app>"
 "</response>";
 
+const char* kInvalidValidXmlMissingCodebase =
+"<?xml version='1.0' encoding='UTF-8'?>"
+"<response protocol='3.0'>"
+" <app appid='12345'>"
+"   <updatecheck status='ok'>"
+"     <urls>"
+"       <url codebasediff='http://diff.example.com/'/>"
+"     </urls>"
+"     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
+"       <packages>"
+"         <package namediff='extension_1_2_3_4.crx'/>"
+"       </packages>"
+"     </manifest>"
+"   </updatecheck>"
+" </app>"
+"</response>";
+
 const char* kMissingAppId =
 "<?xml version='1.0'?>"
 "<response protocol='3.0'>"
 " <app>"
 "  <updatecheck codebase='http://example.com/extension_1.2.3.4.crx'"
 "               version='1.2.3.4' />"
 " </app>"
 "</response>";
 
 const char* kInvalidCodebase =
@@ skipping 128 matching lines @@
   EXPECT_FALSE(parser.errors().empty());
 
   EXPECT_TRUE(parser.Parse(kMissingVersion));
   EXPECT_TRUE(parser.results().list.empty());
   EXPECT_FALSE(parser.errors().empty());
 
   EXPECT_TRUE(parser.Parse(kInvalidVersion));
   EXPECT_TRUE(parser.results().list.empty());
   EXPECT_FALSE(parser.errors().empty());
 
+  EXPECT_TRUE(parser.Parse(kInvalidValidXmlMissingCodebase));
+  EXPECT_TRUE(parser.results().list.empty());
+  EXPECT_FALSE(parser.errors().empty());
+
   // Parse some valid XML, and check that all params came out as expected
   EXPECT_TRUE(parser.Parse(kValidXml));
   EXPECT_TRUE(parser.errors().empty());
   EXPECT_EQ(1u, parser.results().list.size());
   const UpdateResponse::Result* firstResult = &parser.results().list[0];
   EXPECT_EQ(1u, firstResult->crx_urls.size());
   EXPECT_EQ(GURL("http://example.com/"), firstResult->crx_urls[0]);
   EXPECT_EQ(GURL("http://diff.example.com/"), firstResult->crx_diffurls[0]);
   EXPECT_EQ("1.2.3.4", firstResult->manifest.version);
   EXPECT_EQ("2.0.143.0", firstResult->manifest.browser_min_version);
@@ skipping 45 matching lines @@
   // Parse xml with one error and one success <app> tag.
   EXPECT_TRUE(parser.Parse(kTwoAppsOneError));
   EXPECT_FALSE(parser.errors().empty());
   EXPECT_EQ(1u, parser.results().list.size());
   firstResult = &parser.results().list[0];
   EXPECT_EQ(firstResult->extension_id, "bbbbbbbb");
 }
 
 }  // namespace component_updater