Issue 101043009: Remove obsolete about:flags entries on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101043009: Remove obsolete about:flags entries on Windows. (Closed)

Created:
7 years ago by jbauman

Modified:
7 years ago

Reviewers:
vangelis, Vangelis Kokkevis

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove obsolete about:flags entries on Windows. These entries can enable features that are probably broken on Windows, so they shouldn't be allowed there. BUG=329592 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241761

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -43 lines)			Patch
	M	chrome/app/generated_resources.grd	View		2 chunks	+0 lines, -18 lines	0 comments	Download
	M	chrome/browser/about_flags.cc	View	1	6 chunks	+3 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vangelis

Please remove also the strings. Otherwise, LGTM https://codereview.chromium.org/101043009/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/101043009/diff/1/chrome/browser/about_flags.cc#oldcode165 chrome/browser/about_flags.cc:165: We should ...

7 years ago (2013-12-18 21:32:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/101043009/20001

7 years ago (2013-12-18 22:25:00 UTC) #3

Message was sent while issue was closed.

Change committed as 241761

Expand Messages | Collapse Messages