Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1010413003: CodeCleanup: eliminate unnecessary base class and make the children unvirtual. (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Jarin, Rico
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CodeCleanup: eliminate unnecessary base class and make the children unvirtual. I found some strange split in deopt entry points generator. The code for table entry generator had two classes. It is safe to join these classes together and drop virtual. BUG= LOG=n Committed: https://crrev.com/9f91fde045042419dce01f1bde25dee7a48c741e Cr-Commit-Position: refs/heads/master@{#27264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -26 lines) Patch
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 2 chunks +6 lines, -18 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-18 10:18:32 UTC) #2
Jarin
lgtm. thanks for the cleanup!
5 years, 9 months ago (2015-03-18 10:22:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010413003/1
5 years, 9 months ago (2015-03-18 10:28:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 10:34:13 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 10:34:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f91fde045042419dce01f1bde25dee7a48c741e
Cr-Commit-Position: refs/heads/master@{#27264}

Powered by Google App Engine
This is Rietveld 408576698