Source/modules/mediastream/RTCPeerConnection.h - Issue 1010393002: Fix issue of localDescription and remoteDescription getter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediastream/RTCPeerConnection.h

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use SetWrapperReferenceTo. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt ('k') | Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | Source/modules/mediastream/RTCPeerConnection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/mediastream/RTCPeerConnection.h

diff --git a/Source/modules/mediastream/RTCPeerConnection.h b/Source/modules/mediastream/RTCPeerConnection.h

index bf040004b0b42800cbc8daa0bbb574c116439bfa..b9cf902c008c7eb949035be70dee2cc4833c3894 100644

--- a/Source/modules/mediastream/RTCPeerConnection.h

+++ b/Source/modules/mediastream/RTCPeerConnection.h

@@ -71,10 +71,10 @@ public:

void createAnswer(RTCSessionDescriptionCallback*, RTCErrorCallback*, const Dictionary&, ExceptionState&);

void setLocalDescription(RTCSessionDescription*, VoidCallback*, RTCErrorCallback*, ExceptionState&);

- RTCSessionDescription* localDescription(ExceptionState&);

+ RTCSessionDescription* localDescription();

void setRemoteDescription(RTCSessionDescription*, VoidCallback*, RTCErrorCallback*, ExceptionState&);

- RTCSessionDescription* remoteDescription(ExceptionState&);

+ RTCSessionDescription* remoteDescription();

String signalingState() const;

@@ -164,6 +164,8 @@ private:

void closeInternal();

+ Member<RTCSessionDescription> m_localDescription;

+ Member<RTCSessionDescription> m_remoteDescription;

SignalingState m_signalingState;

ICEGatheringState m_iceGatheringState;

ICEConnectionState m_iceConnectionState;