Fix issue of localDescription and remoteDescription getter.

Source/modules/mediastream/RTCSessionDescription.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 19 matching lines @@
 
 #include "config.h"
 #include "modules/mediastream/RTCSessionDescription.h"
 
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8ObjectBuilder.h"
 #include "modules/mediastream/RTCSessionDescriptionInit.h"
 
 namespace blink {
 
-RTCSessionDescription* RTCSessionDescription::create(const RTCSessionDescriptionInit& descriptionInitDict)
+RTCSessionDescription* RTCSessionDescription::create(ExecutionContext* context, const RTCSessionDescriptionInit& descriptionInitDict)
 {
     String type;
     if (descriptionInitDict.hasType())
         type = descriptionInitDict.type();
 
     String sdp;
     if (descriptionInitDict.hasSdp())
         sdp = descriptionInitDict.sdp();
 
-    return new RTCSessionDescription(WebRTCSessionDescription(type, sdp));
+    return new RTCSessionDescription(context, WebRTCSessionDescription(type, sdp));
 }
 
-RTCSessionDescription* RTCSessionDescription::create(WebRTCSessionDescription webSessionDescription)
+RTCSessionDescription* RTCSessionDescription::create(ExecutionContext* context, WebRTCSessionDescription webSessionDescription)
 {
-    return new RTCSessionDescription(webSessionDescription);
+    return new RTCSessionDescription(context, webSessionDescription);
 }
 
-RTCSessionDescription::RTCSessionDescription(WebRTCSessionDescription webSessionDescription)
-    : m_webSessionDescription(webSessionDescription)
+RTCSessionDescription::RTCSessionDescription(ExecutionContext* context, WebRTCSessionDescription webSessionDescription)
+    : ActiveDOMObject(context)
+    , m_webSessionDescription(webSessionDescription)
 {
 }
 
 String RTCSessionDescription::type()
 {
     return m_webSessionDescription.type();
 }
 
 void RTCSessionDescription::setType(const String& type)
 {
@@ skipping 22 matching lines @@
     else
         result.addString("sdp", sdp());
     return result.scriptValue();
 }
 
 WebRTCSessionDescription RTCSessionDescription::webSessionDescription()
 {
     return m_webSessionDescription;
 }
 
+void RTCSessionDescription::setWebSessionDescription(WebRTCSessionDescription webSessionDescription)
+{
+    m_webSessionDescription = webSessionDescription;
+}
+
+bool RTCSessionDescription::hasPendingActivity() const
+{
+    return false;

[jochen (gone - plz use gerrit), 2015/04/22 14:48:40]

hasPendingActivity should return true as long as this object can potentially be
exposed to javascript.

note that it won't die as long as it returns true, so you can't just blanket
return true here

[changbin, 2015/04/24 09:22:33]

Then one factor that determines RTCSessionDescription object's life is
RTCPeerConnection, right? I mean if RTCPeerConnection is no long alive, then its
member m_localDescription and m_localDescription should also be released.
If above is true, then why do we make RTCSessionDescription an active dom
object? Since RTCPeerConnection is active dom object, I think its member values
won't be released until the object isn't alive, is that right?
Please forgive me that I am still confused on why have to make RTCPeerConnection
active dom object:)  

 

+}
+
+void RTCSessionDescription::stop()
+{
+}
+
+DEFINE_TRACE(RTCSessionDescription)
+{
+    ActiveDOMObject::trace(visitor);
+}
+
 } // namespace blink