Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 101033002: Add sysroot script for armhf linux. (Closed)

Created:
7 years ago by Sam Clegg
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 7

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -42 lines) Patch
M chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.amd64 View 1 3 chunks +7 lines, -7 lines 0 comments Download
A chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm View 1 1 chunk +158 lines, -0 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.i386 View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh View 1 2 3 15 chunks +104 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
6 years, 7 months ago (2014-05-12 21:28:59 UTC) #1
Lei Zhang
https://codereview.chromium.org/101033002/diff/40001/chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm File chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm (right): https://codereview.chromium.org/101033002/diff/40001/chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm#newcode35 chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm:35: main/g/gconf/libgconf-2-4_3.2.5-1+build1_armhf.deb nit: alphabetical order https://codereview.chromium.org/101033002/diff/40001/chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh File chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh (right): https://codereview.chromium.org/101033002/diff/40001/chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh#newcode307 ...
6 years, 7 months ago (2014-05-12 21:45:37 UTC) #2
Sam Clegg
https://codereview.chromium.org/101033002/diff/40001/chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm File chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm (right): https://codereview.chromium.org/101033002/diff/40001/chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm#newcode35 chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.arm:35: main/g/gconf/libgconf-2-4_3.2.5-1+build1_armhf.deb On 2014/05/12 21:45:37, Lei Zhang wrote: > nit: ...
6 years, 7 months ago (2014-05-12 22:25:32 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/101033002/diff/40001/chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh File chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh (right): https://codereview.chromium.org/101033002/diff/40001/chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh#newcode307 chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh:307: TMP=/tmp/$USER/debian-wheezy-sysroot On 2014/05/12 22:25:32, Sam Clegg wrote: > ...
6 years, 7 months ago (2014-05-12 22:34:17 UTC) #4
Sam Clegg
6 years, 7 months ago (2014-05-13 00:04:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r269929 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698