Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 10103012: GTK: Stop listening to gtk signals in the omnibox before destroying the model. (Closed)

Created:
6 years, 10 months ago by Elliot Glaysher
Modified:
6 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

GTK: Stop listening to gtk signals in the omnibox before destroying the model. BUG=123530 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 4 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
6 years, 10 months ago (2012-04-16 22:25:40 UTC) #1
inferno
Sorry but I don't know anything about this code. Please find a reviewer from the ...
6 years, 10 months ago (2012-04-16 22:42:30 UTC) #2
Elliot Glaysher
switching to Lei
6 years, 10 months ago (2012-04-16 22:46:47 UTC) #3
Lei Zhang
lgtm
6 years, 10 months ago (2012-04-16 23:05:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10103012/1
6 years, 10 months ago (2012-04-16 23:10:39 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2012-04-17 00:57:32 UTC) #6
Change committed as 132498

Powered by Google App Engine
This is Rietveld 408576698