Issue 10103012: GTK: Stop listening to gtk signals in the omnibox before destroying the model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10103012: GTK: Stop listening to gtk signals in the omnibox before destroying the model. (Closed)

Created:
8 years, 8 months ago by Elliot Glaysher

Modified:
8 years, 8 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

GTK: Stop listening to gtk signals in the omnibox before destroying the model. BUG=123530 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132498

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
	M	chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc	View		4 chunks	+15 lines, -9 lines	0 comments	Download

Total messages: 6 (0 generated)

inferno

Sorry but I don't know anything about this code. Please find a reviewer from the ...

8 years, 8 months ago (2012-04-16 22:42:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10103012/1

8 years, 8 months ago (2012-04-16 23:10:39 UTC) #5

Change committed as 132498