Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 1010263002: [Autofill] Add FormEvent logging for "will submit form". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: split Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 0ccf7d90feb92c60ca7d0ad4e271d7536f116b81..099cc6361ecabca5085d76efe5bcbf3491db47b1 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -328,8 +328,8 @@ bool AutofillManager::OnWillSubmitForm(const FormData& form,
if (!submitted_form)
return false;
- address_form_event_logger_->OnDidSubmitForm();
- credit_card_form_event_logger_->OnDidSubmitForm();
+ address_form_event_logger_->OnWillSubmitForm();
+ credit_card_form_event_logger_->OnWillSubmitForm();
// Only upload server statistics and UMA metrics if at least some local data
// is available to use as a baseline.
@@ -389,6 +389,9 @@ bool AutofillManager::OnFormSubmitted(const FormData& form) {
if (!submitted_form)
return false;
+ address_form_event_logger_->OnFormSubmitted();
+ credit_card_form_event_logger_->OnFormSubmitted();
+
// Update Personal Data with the form's submitted data.
if (submitted_form->IsAutofillable())
ImportFormData(*submitted_form);
« no previous file with comments | « components/autofill/core/browser/autofill_manager.h ('k') | components/autofill/core/browser/autofill_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698