Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 1010263002: [Autofill] Add FormEvent logging for "will submit form". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index 78540dc4127fcf47760472d4b5302386781ac989..b7cff968d914d958d1e61589fe0fee1f5a353e47 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -269,6 +269,10 @@ class AutofillMetrics {
FORM_EVENT_LOCAL_SUGGESTION_FILLED_ONCE,
FORM_EVENT_SERVER_SUGGESTION_FILLED_ONCE,
FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED_ONCE,
+ // An autofillable form is about to be submitted. If the submission is not
+ // interrupted by JavaScript, the "form submitted" events below will also be
+ // logged.
+ FORM_EVENT_WILL_SUBMIT,
Ilya Sherman 2015/03/18 22:42:10 Why are you adding this event in the middle of the
Mathieu 2015/03/23 15:24:02 Done. Yes of course.
// A form was submitted. Depending on the user filling a local, server,
// masked server card or no suggestion one of the following will be
// triggered. Only one of the following four will be triggered per page
@@ -281,6 +285,7 @@ class AutofillMetrics {
FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SELECTED,
// Same as above but only triggered once per page load.
FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SELECTED_ONCE,
+
NUM_FORM_EVENTS,
};
@@ -494,6 +499,8 @@ class AutofillMetrics {
void OnDidFillSuggestion(const AutofillProfile& profile);
+ void OnWillSubmitForm();
+
void OnDidSubmitForm();
private:

Powered by Google App Engine
This is Rietveld 408576698