[Autofill] Add FormEvent logging for "will submit form".

components/autofill/core/browser/autofill_metrics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
@@ skipping 211 matching lines @@
     for (size_t i = 0; i < empty_form.fields.size(); ++i) {
       empty_form.fields[i].value = base::string16();
     }
 
     // |form_structure| will be owned by |form_structures()|.
     TestFormStructure* form_structure = new TestFormStructure(empty_form);
     form_structure->SetFieldTypes(heuristic_types, server_types);
     form_structures()->push_back(form_structure);
   }
 
-  void WillSubmitForm(const FormData& form, const TimeTicks& timestamp) {
+  // Calls both OnWillSubmitForm and OnFormSubmitted.

[Ilya Sherman, 2015/03/18 22:42:10]

Please add test coverage for OnWillSubmitForm being called, without a subsequent
call to OnFormSubmitted.  (Or did I miss the place where this is already
tested?)

[Mathieu, 2015/03/23 15:24:02]

Done.

+  void SubmitForm(const FormData& form, const TimeTicks& timestamp) {
     run_loop_.reset(new base::RunLoop());
     if (!OnWillSubmitForm(form, timestamp))
       return;
 
     // Wait for the asynchronous OnWillSubmitForm() call to complete.
     run_loop_->Run();
+
+    OnFormSubmitted(form);
   }
 
   void UploadFormDataAsyncCallback(
       const FormStructure* submitted_form,
       const base::TimeTicks& load_time,
       const base::TimeTicks& interaction_time,
       const base::TimeTicks& submission_time) override {
     run_loop_->Quit();
 
     AutofillManager::UploadFormDataAsyncCallback(submitted_form,
@@ skipping 121 matching lines @@
   field.is_autofilled = true;
   form.fields.push_back(field);
   heuristic_types.push_back(PHONE_HOME_CITY_AND_NUMBER);
   server_types.push_back(PHONE_HOME_WHOLE_NUMBER);
 
   // Simulate having seen this form on page load.
   autofill_manager_->AddSeenForm(form, heuristic_types, server_types);
 
   // Simulate form submission.
   base::HistogramTester histogram_tester;
-  autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+  autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
   // Heuristic predictions.
   // Unknown:
   histogram_tester.ExpectBucketCount("Autofill.Quality.HeuristicType",
                                      AutofillMetrics::TYPE_UNKNOWN, 1);
   histogram_tester.ExpectBucketCount(
       "Autofill.Quality.HeuristicType.ByFieldType",
       GetFieldTypeGroupMetric(ADDRESS_HOME_COUNTRY,
                               AutofillMetrics::TYPE_UNKNOWN),
       1);
@@ skipping 101 matching lines @@
   test::CreateTestFormField("Phone", "phone", "2345678901", "tel", &field);
   field.is_autofilled = true;
   form.fields.push_back(field);
   heuristic_types.push_back(PHONE_HOME_CITY_AND_NUMBER);
   server_types.push_back(EMAIL_ADDRESS);
 
   // Simulate having seen this form on page load.
   autofill_manager_->AddSeenForm(form, heuristic_types, server_types);
 
   // Simulate form submission.
-  autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+  autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
   // The number of mismatches did not trigger the RAPPOR metric logging.
   EXPECT_EQ(0, autofill_client_.test_rappor_service()->GetReportsCount());
 }
 
 // Test that we don't log RAPPOR metrics in the case heuristics and/or server
 // have no data.
 TEST_F(AutofillMetricsTest, Rappor_NoDataServerAndHeuristic_NoMetricsReported) {
   // Set up our form data.
   FormData form;
@@ skipping 22 matching lines @@
   test::CreateTestFormField("Phone", "phone", "2345678901", "tel", &field);
   field.is_autofilled = true;
   form.fields.push_back(field);
   heuristic_types.push_back(UNKNOWN_TYPE);
   server_types.push_back(NO_SERVER_DATA);
 
   // Simulate having seen this form on page load.
   autofill_manager_->AddSeenForm(form, heuristic_types, server_types);
 
   // Simulate form submission.
-  autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+  autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
   // No RAPPOR metrics are logged in the case of multiple UNKNOWN_TYPE and
   // NO_SERVER_DATA for heuristics and server predictions, respectively.
   EXPECT_EQ(0, autofill_client_.test_rappor_service()->GetReportsCount());
 }
 
 // Test that we log high number of mismatches for the server prediction.
 TEST_F(AutofillMetricsTest, Rappor_HighServerMismatchRate_MetricsReported) {
   // Set up our form data.
   FormData form;
@@ skipping 22 matching lines @@
   test::CreateTestFormField("Phone", "phone", "2345678901", "tel", &field);
   field.is_autofilled = true;
   form.fields.push_back(field);
   heuristic_types.push_back(PHONE_HOME_CITY_AND_NUMBER);
   server_types.push_back(EMAIL_ADDRESS);
 
   // Simulate having seen this form on page load.
   autofill_manager_->AddSeenForm(form, heuristic_types, server_types);
 
   // Simulate form submission.
-  autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+  autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
   // The number of mismatches did trigger the RAPPOR metric logging for server
   // predictions.
   EXPECT_EQ(1, autofill_client_.test_rappor_service()->GetReportsCount());
   std::string sample;
   rappor::RapporType type;
   EXPECT_FALSE(
       autofill_client_.test_rappor_service()->GetRecordedSampleForMetric(
           "Autofill.HighNumberOfHeuristicMismatches", &sample, &type));
   EXPECT_TRUE(
@@ skipping 32 matching lines @@
   test::CreateTestFormField("Phone", "phone", "2345678901", "tel", &field);
   field.is_autofilled = true;
   form.fields.push_back(field);
   heuristic_types.push_back(EMAIL_ADDRESS);
   server_types.push_back(PHONE_HOME_WHOLE_NUMBER);
 
   // Simulate having seen this form on page load.
   autofill_manager_->AddSeenForm(form, heuristic_types, server_types);
 
   // Simulate form submission.
-  autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+  autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
   // The number of mismatches did trigger the RAPPOR metric logging for
   // heuristic predictions.
   EXPECT_EQ(1, autofill_client_.test_rappor_service()->GetReportsCount());
   std::string sample;
   rappor::RapporType type;
   EXPECT_FALSE(
       autofill_client_.test_rappor_service()->GetRecordedSampleForMetric(
           "Autofill.HighNumberOfServerMismatches", &sample, &type));
   EXPECT_TRUE(
@@ skipping 32 matching lines @@
   std::vector<FormData> forms(1, form);
 
   {
     base::HistogramTester histogram_tester;
     autofill_manager_->OnFormsSeen(forms, TimeTicks());
     // We change the value of the text fields to change the default/seen values
     // (hence the values are not cleared in UpdateFromCache). The new values
     // match what is in the test profile.
     form.fields[1].value = base::ASCIIToUTF16("79401");
     form.fields[2].value = base::ASCIIToUTF16("2345678901");
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
     // First verify that country was not predicted by client or server.
     histogram_tester.ExpectBucketCount(
         "Autofill.Quality.ServerType.ByFieldType",
         GetFieldTypeGroupMetric(ADDRESS_HOME_COUNTRY,
                                 AutofillMetrics::TYPE_UNKNOWN),
         1);
     histogram_tester.ExpectBucketCount(
         "Autofill.Quality.HeuristicType.ByFieldType",
         GetFieldTypeGroupMetric(ADDRESS_HOME_COUNTRY,
@@ skipping 92 matching lines @@
   test::CreateTestFormField(
       "New field", "new field", "Tennessee", "text", &field);
   form.fields.push_back(field);
   form.fields.push_back(cached_fields[2]);
   form.fields.push_back(cached_fields[1]);
   form.fields.push_back(cached_fields[3]);
   form.fields.push_back(cached_fields[0]);
 
   // Simulate form submission.
   base::HistogramTester histogram_tester;
-  autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+  autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
   // Heuristic predictions.
   // Unknown:
   histogram_tester.ExpectBucketCount("Autofill.Quality.HeuristicType",
                                      AutofillMetrics::TYPE_UNKNOWN, 1);
   histogram_tester.ExpectBucketCount(
       "Autofill.Quality.HeuristicType.ByFieldType",
       GetFieldTypeGroupMetric(ADDRESS_HOME_STATE,
                               AutofillMetrics::TYPE_UNKNOWN),
       1);
@@ skipping 89 matching lines @@
   test::CreateTestFormField("Email", "email", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Phone", "phone", "", "text", &field);
   form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
 
   // Simulate form submission.
   base::HistogramTester histogram_tester;
   autofill_manager_->OnFormsSeen(forms, TimeTicks());
-  autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+  autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
   // An autofillable form was submitted, and the number of stored profiles is
   // logged.
   histogram_tester.ExpectUniqueSample(
       "Autofill.StoredProfileCountAtAutofillableFormSubmission", 2, 1);
 }
 
 // Verify that when submitting a non-autofillable form, the stored profile
 // metric is not logged.
 TEST_F(AutofillMetricsTest, StoredProfileCountNonAutofillableFormSubmission) {
   // Construct a non-fillable form.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
   form.origin = GURL("http://example.com/form.html");
   form.action = GURL("http://example.com/submit.html");
   form.user_submitted = true;
 
   // Two fields is not enough to make it an autofillable form.
   FormFieldData field;
   test::CreateTestFormField("Name", "name", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Email", "email", "", "text", &field);
   form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
 
   // Simulate form submission.
   base::HistogramTester histogram_tester;
   autofill_manager_->OnFormsSeen(forms, TimeTicks());
-  autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+  autofill_manager_->SubmitForm(form, TimeTicks::Now());
 
   // A non-autofillable form was submitted, and number of stored profiles is NOT
   // logged.
   histogram_tester.ExpectTotalCount(
       "Autofill.StoredProfileCountAtAutofillableFormSubmission", 0);
 }
 
 // Verify that we correctly log metrics regarding developer engagement.
 TEST_F(AutofillMetricsTest, DeveloperEngagement) {
   // Start with a non-fillable form.
@@ skipping 525 matching lines @@
 
   // Simulate having seen this form on page load.
   // |form_structure| will be owned by |autofill_manager_|.
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating submission with no filled data.
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect(),
                                                 false);
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.CreditCard",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       1);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE, 1);
   }
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating submission with filled local data.
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect(),
                                                 false);
     SuggestionBackendID guid(
         "10000000-0000-0000-0000-000000000001", 0); // local card
     autofill_manager_->FillOrPreviewForm(
         AutofillDriver::FORM_DATA_ACTION_FILL,
         0, form, form.fields.front(),
         autofill_manager_->MakeFrontendID(guid, SuggestionBackendID()));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.CreditCard",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       1);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE, 1);
   }
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating submission with filled server data.
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect(),
                                                 false);
     SuggestionBackendID guid(
         "10000000-0000-0000-0000-000000000003", 0); // full server card
     autofill_manager_->FillOrPreviewForm(
         AutofillDriver::FORM_DATA_ACTION_FILL,
         0, form, form.fields.front(),
         autofill_manager_->MakeFrontendID(guid, SuggestionBackendID()));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.CreditCard",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       1);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE, 1);
   }
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
@@ skipping 25 matching lines @@
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating multiple submissions.
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect(),
                                                 false);
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.CreditCard",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       2);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE, 1);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE, 0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE, 0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics
             ::FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SUBMITTED_ONCE,
         0);
   }
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating submission without previous interaction.
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.CreditCard",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE, 0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE, 0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.CreditCard",
         AutofillMetrics::FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE, 0);
   }
@@ skipping 247 matching lines @@
 
   // Simulate having seen this form on page load.
   // |form_structure| will be owned by |autofill_manager_|.
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating submission with no filled data.
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect(),
                                                 false);
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.Address",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       1);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE, 1);
   }
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating submission with filled local data.
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect(),
                                                 false);
     SuggestionBackendID guid(
         "00000000-0000-0000-0000-000000000001", 0); // local profile
     autofill_manager_->FillOrPreviewForm(
         AutofillDriver::FORM_DATA_ACTION_FILL,
         0, form, form.fields.front(),
         autofill_manager_->MakeFrontendID(SuggestionBackendID(), guid));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.Address",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       1);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE, 1);
   }
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating submission with filled server data.
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect(),
                                                 false);
     SuggestionBackendID guid(
         "00000000-0000-0000-0000-000000000002", 0); // server profile
     autofill_manager_->FillOrPreviewForm(
         AutofillDriver::FORM_DATA_ACTION_FILL,
         0, form, form.fields.front(),
         autofill_manager_->MakeFrontendID(SuggestionBackendID(), guid));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.Address",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       1);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE, 1);
   }
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating multiple submissions.
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect(),
                                                 false);
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.Address",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       2);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE, 1);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE, 0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE, 0);
   }
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
   autofill_manager_->AddSeenForm(form, field_types, field_types);
 
   {
     // Simulating submission without previous interaction.
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
+    histogram_tester.ExpectBucketCount("Autofill.FormEvents.Address",
+                                       AutofillMetrics::FORM_EVENT_WILL_SUBMIT,
+                                       0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE, 0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE, 0);
     histogram_tester.ExpectBucketCount(
         "Autofill.FormEvents.Address",
         AutofillMetrics::FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE, 0);
   }
@@ skipping 240 matching lines @@
   {
     base::HistogramTester histogram_tester;
     autofill_manager_->OnFormsSeen(forms, TimeTicks());
     histogram_tester.ExpectTotalCount("Autofill.UserHappiness", 0);
   }
 
 
   // Expect no notifications when the form is submitted.
   {
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
     histogram_tester.ExpectTotalCount("Autofill.UserHappiness", 0);
   }
 
   // Add more fields to the form.
   test::CreateTestFormField("Phone", "phone", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Unknown", "unknown", "", "text", &field);
   form.fields.push_back(field);
   forms.front() = form;
 
   // Expect a notification when the form is first seen.
   {
     base::HistogramTester histogram_tester;
     autofill_manager_->OnFormsSeen(forms, TimeTicks());
     histogram_tester.ExpectUniqueSample("Autofill.UserHappiness",
                                         AutofillMetrics::FORMS_LOADED, 1);
   }
 
   // Expect a notification when the form is submitted.
   {
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
     histogram_tester.ExpectUniqueSample(
         "Autofill.UserHappiness", AutofillMetrics::SUBMITTED_NON_FILLABLE_FORM,
         1);
   }
 
   // Fill in two of the fields.
   form.fields[0].value = ASCIIToUTF16("Elvis Aaron Presley");
   form.fields[1].value = ASCIIToUTF16("theking@gmail.com");
   forms.front() = form;
 
   // Expect a notification when the form is submitted.
   {
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
     histogram_tester.ExpectUniqueSample(
         "Autofill.UserHappiness", AutofillMetrics::SUBMITTED_NON_FILLABLE_FORM,
         1);
   }
 
   // Fill in the third field.
   form.fields[2].value = ASCIIToUTF16("12345678901");
   forms.front() = form;
 
   // Expect notifications when the form is submitted.
   {
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
     histogram_tester.ExpectUniqueSample(
         "Autofill.UserHappiness",
         AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_NONE, 1);
   }
 
 
   // Mark one of the fields as autofilled.
   form.fields[1].is_autofilled = true;
   forms.front() = form;
 
   // Expect notifications when the form is submitted.
   {
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
     histogram_tester.ExpectUniqueSample(
         "Autofill.UserHappiness",
         AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_SOME, 1);
   }
 
   // Mark all of the fillable fields as autofilled.
   form.fields[0].is_autofilled = true;
   form.fields[2].is_autofilled = true;
   forms.front() = form;
 
   // Expect notifications when the form is submitted.
   {
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
     histogram_tester.ExpectUniqueSample(
         "Autofill.UserHappiness",
         AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_ALL, 1);
   }
 
   // Clear out the third field's value.
   form.fields[2].value = base::string16();
   forms.front() = form;
 
   // Expect notifications when the form is submitted.
   {
     base::HistogramTester histogram_tester;
-    autofill_manager_->WillSubmitForm(form, TimeTicks::Now());
+    autofill_manager_->SubmitForm(form, TimeTicks::Now());
     histogram_tester.ExpectUniqueSample(
         "Autofill.UserHappiness", AutofillMetrics::SUBMITTED_NON_FILLABLE_FORM,
         1);
   }
 }
 
 // Verify that we correctly log user happiness metrics dealing with form
 // interaction.
 TEST_F(AutofillMetricsTest, UserHappinessFormInteraction) {
   // Load a fillable form.
@@ skipping 135 matching lines @@
   second_form.fields[0].value = ASCIIToUTF16("Elvis Aaron Presley");
   second_form.fields[1].value = ASCIIToUTF16("theking@gmail.com");
   second_form.fields[2].value = ASCIIToUTF16("12345678901");
   second_form.fields[3].value = ASCIIToUTF16("51512345678");
 
   // Expect only form load metrics to be logged if the form is submitted without
   // user interaction.
   {
     base::HistogramTester histogram_tester;
     autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::FromInternalValue(17));
+    autofill_manager_->SubmitForm(form, TimeTicks::FromInternalValue(17));
 
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromLoad.WithAutofill", 0);
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromLoad.WithoutAutofill", 16, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithAutofill", 0);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithoutAutofill", 0);
 
     autofill_manager_->Reset();
   }
 
   // Expect metric to be logged if the user manually edited a form field.
   {
     base::HistogramTester histogram_tester;
     autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
     autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
                                             TimeTicks::FromInternalValue(3));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::FromInternalValue(17));
+    autofill_manager_->SubmitForm(form, TimeTicks::FromInternalValue(17));
 
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromLoad.WithAutofill", 0);
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromLoad.WithoutAutofill", 16, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithAutofill", 0);
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromInteraction.WithoutAutofill", 14, 1);
 
     autofill_manager_->Reset();
   }
 
   // Expect metric to be logged if the user autofilled the form.
   form.fields[0].is_autofilled = true;
   {
     base::HistogramTester histogram_tester;
     autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
     autofill_manager_->OnDidFillAutofillFormData(
         TimeTicks::FromInternalValue(5));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::FromInternalValue(17));
+    autofill_manager_->SubmitForm(form, TimeTicks::FromInternalValue(17));
 
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromLoad.WithAutofill", 16, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromLoad.WithoutAutofill", 0);
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromInteraction.WithAutofill", 12, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithoutAutofill", 0);
 
     autofill_manager_->Reset();
   }
 
   // Expect metric to be logged if the user both manually filled some fields
   // and autofilled others.  Messages can arrive out of order, so make sure they
   // take precedence appropriately.
   {
     base::HistogramTester histogram_tester;
 
     autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
     autofill_manager_->OnDidFillAutofillFormData(
         TimeTicks::FromInternalValue(5));
     autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
                                             TimeTicks::FromInternalValue(3));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::FromInternalValue(17));
+    autofill_manager_->SubmitForm(form, TimeTicks::FromInternalValue(17));
 
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromLoad.WithAutofill", 16, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromLoad.WithoutAutofill", 0);
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromInteraction.WithAutofill", 14, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithoutAutofill", 0);
 
     autofill_manager_->Reset();
   }
 
   // Make sure that loading another form doesn't affect metrics from the first
   // form.
   {
     base::HistogramTester histogram_tester;
     autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
     autofill_manager_->OnFormsSeen(second_forms,
                                    TimeTicks::FromInternalValue(3));
     autofill_manager_->OnDidFillAutofillFormData(
         TimeTicks::FromInternalValue(5));
     autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
                                             TimeTicks::FromInternalValue(3));
-    autofill_manager_->WillSubmitForm(form, TimeTicks::FromInternalValue(17));
+    autofill_manager_->SubmitForm(form, TimeTicks::FromInternalValue(17));
 
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromLoad.WithAutofill", 16, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromLoad.WithoutAutofill", 0);
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromInteraction.WithAutofill", 14, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithoutAutofill", 0);
 
     autofill_manager_->Reset();
   }
 
   // Make sure that submitting a form that was loaded later will report the
   // later loading time.
   {
     base::HistogramTester histogram_tester;
     autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
     autofill_manager_->OnFormsSeen(second_forms,
                                    TimeTicks::FromInternalValue(5));
-    autofill_manager_->WillSubmitForm(second_form,
-                                      TimeTicks::FromInternalValue(17));
+    autofill_manager_->SubmitForm(second_form,
+                                  TimeTicks::FromInternalValue(17));
 
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromLoad.WithAutofill", 0);
     histogram_tester.ExpectUniqueSample(
         "Autofill.FillDuration.FromLoad.WithoutAutofill", 12, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithAutofill", 0);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithoutAutofill", 0);
 
     autofill_manager_->Reset();
   }
 }
 
 }  // namespace autofill