[Autofill] Add FormEvent logging for "will submit form".

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 310 matching lines @@
 
 bool AutofillManager::OnWillSubmitForm(const FormData& form,
                                        const TimeTicks& timestamp) {
   if (!IsValidFormData(form))
     return false;
 
   scoped_ptr<FormStructure> submitted_form = ValidateSubmittedForm(form);
   if (!submitted_form)
     return false;
 
-  address_form_event_logger_->OnDidSubmitForm();
-  credit_card_form_event_logger_->OnDidSubmitForm();
+  address_form_event_logger_->OnWillSubmitForm();
+  credit_card_form_event_logger_->OnWillSubmitForm();
 
   // Only upload server statistics and UMA metrics if at least some local data
   // is available to use as a baseline.
   const std::vector<AutofillProfile*>& profiles = personal_data_->GetProfiles();
   if (submitted_form->IsAutofillable()) {
     AutofillMetrics::LogNumberOfProfilesAtAutofillableFormSubmission(
         personal_data_->GetProfiles().size());
   }
   const std::vector<CreditCard*>& credit_cards =
       personal_data_->GetCreditCards();
@@ skipping 39 matching lines @@
   if (!IsValidFormData(form))
     return false;
 
   // Let Autocomplete know as well.
   autocomplete_history_manager_->OnFormSubmitted(form);
 
   scoped_ptr<FormStructure> submitted_form = ValidateSubmittedForm(form);
   if (!submitted_form)
     return false;
 
+  address_form_event_logger_->OnDidSubmitForm();
+  credit_card_form_event_logger_->OnDidSubmitForm();

[Evan Stade, 2015/03/20 20:55:03]

can we keep the names the same? i.e. OnFormSubmitted (or fix the slightly weird
discrepancy between AutofillManager::OnFormSubmitted and OnWillSubmitForm)

[Mathieu, 2015/03/23 15:24:02]

Sure, renamed OnDidSubmitForm to OnFormSubmitted.

+
   // Update Personal Data with the form's submitted data.
   if (submitted_form->IsAutofillable())
     ImportFormData(*submitted_form);
 
   return true;
 }
 
 void AutofillManager::OnFormsSeen(const std::vector<FormData>& forms,
                                   const TimeTicks& timestamp) {
   if (!IsValidFormDataVector(forms))
@@ skipping 1060 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed())
     return false;
 
   return true;
 }
 
 }  // namespace autofill