[Autofill] Add FormEvent logging for "will submit form".

components/autofill/core/browser/autofill_metrics.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
@@ skipping 263 matching lines @@
     // triggered. Only one of the following four will be triggered per page
     // load.
     FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE,
     FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE,
     FORM_EVENT_SERVER_SUGGESTION_SUBMITTED_ONCE,
     FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SUBMITTED_ONCE,
     // A masked server card suggestion was selected to fill the form.
     FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SELECTED,
     // Same as above but only triggered once per page load.
     FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_SELECTED_ONCE,
+    // An autofillable form is about to be submitted. If the submission is not
+    // interrupted by JavaScript, the "form submitted" events below will also be

[Ilya Sherman, 2015/03/23 20:58:16]

nit: "below" -> "above"

[Mathieu, 2015/03/23 21:11:28]

Done.

+    // logged. Triggered once per page load.

[Ilya Sherman, 2015/03/23 20:58:17]

nit: "once" -> "at most once"

[Mathieu, 2015/03/23 21:11:28]

Done.

+    FORM_EVENT_WILL_SUBMIT_ONCE,
+
     NUM_FORM_EVENTS,
   };
 
   // Events related to the Unmask Credit Card Prompt.
   enum UnmaskPromptEvent {
     // The prompt was shown.
     UNMASK_PROMPT_SHOWN = 0,
     // The prompt was closed without attempting to unmask the card.
     UNMASK_PROMPT_CLOSED_NO_ATTEMPTS,
     // The prompt was closed without unmasking the card, but with at least
@@ skipping 245 matching lines @@
     void OnDidShowSuggestions();
 
     void OnDidSelectMaskedServerCardSuggestion();
 
     // In case of masked cards, caller must make sure this gets called before
     // the card is upgraded to a full card.
     void OnDidFillSuggestion(const CreditCard& credit_card);
 
     void OnDidFillSuggestion(const AutofillProfile& profile);
 
-    void OnDidSubmitForm();
+    void OnWillSubmitForm();
+
+    void OnFormSubmitted();
 
    private:
     void Log(FormEvent event) const;
 
     bool is_for_credit_card_;
     bool is_server_data_available_;
     bool is_local_data_available_;
     bool has_logged_interacted_;
     bool has_logged_suggestions_shown_;
     bool has_logged_masked_server_card_suggestion_selected_;
     bool has_logged_suggestion_filled_;
+    bool has_logged_will_submit_;
     bool has_logged_submitted_;
     bool logged_suggestion_filled_was_server_data_;
     bool logged_suggestion_filled_was_masked_server_card_;
   };
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_