[Autofill] Add FormEvent logging for "will submit form".

components/autofill/core/browser/autofill_metrics.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/time/time.h"
@@ skipping 504 matching lines @@
 }
 
 AutofillMetrics::FormEventLogger::FormEventLogger(bool is_for_credit_card)
     : is_for_credit_card_(is_for_credit_card),
       is_server_data_available_(false),
       is_local_data_available_(false),
       has_logged_interacted_(false),
       has_logged_suggestions_shown_(false),
       has_logged_masked_server_card_suggestion_selected_(false),
       has_logged_suggestion_filled_(false),
+      has_logged_will_submit_(false),
       has_logged_submitted_(false),
       logged_suggestion_filled_was_server_data_(false),
-      logged_suggestion_filled_was_masked_server_card_(false) {};
+      logged_suggestion_filled_was_masked_server_card_(false){};

[Ilya Sherman, 2015/03/23 20:58:16]

nit: Please revert the diff on this line.  Also, while you're here, please drop
the semicolon on this line.

[Mathieu, 2015/03/23 21:11:28]

This is the work of "git cl format" but removing the semi-colon makes it nice
again.

 
 void AutofillMetrics::FormEventLogger::OnDidInteractWithAutofillableForm() {
   if (!has_logged_interacted_) {
     has_logged_interacted_ = true;
     Log(AutofillMetrics::FORM_EVENT_INTERACTED_ONCE);
   }
 }
 
 void AutofillMetrics::FormEventLogger::OnDidShowSuggestions() {
   Log(AutofillMetrics::FORM_EVENT_SUGGESTIONS_SHOWN);
@@ skipping 52 matching lines @@
   if (!has_logged_suggestion_filled_) {
     has_logged_suggestion_filled_ = true;
     logged_suggestion_filled_was_server_data_ =
         profile.record_type() == AutofillProfile::SERVER_PROFILE;
     Log(profile.record_type() == AutofillProfile::SERVER_PROFILE
         ? AutofillMetrics::FORM_EVENT_SERVER_SUGGESTION_FILLED_ONCE
         : AutofillMetrics::FORM_EVENT_LOCAL_SUGGESTION_FILLED_ONCE);
   }
 }
 
-void AutofillMetrics::FormEventLogger::OnDidSubmitForm() {
+void AutofillMetrics::FormEventLogger::OnWillSubmitForm() {
   // Not logging this kind of form if we haven't logged a user interaction.
   if (!has_logged_interacted_)
     return;
+
+  // Not logging twice.
+  if (has_logged_will_submit_)
+    return;
+  has_logged_will_submit_ = true;
+
+  Log(AutofillMetrics::FORM_EVENT_WILL_SUBMIT_ONCE);

[Ilya Sherman, 2015/03/23 20:58:16]

Do we want to split up the WILL_SUBMIT_* metrics the same way we do the
SUBMITTED_* ones?  For some forms, we'll only see the "WILL_SUBMIT" metrics,
right?

[Mathieu, 2015/03/23 21:11:28]

Yes some forms will only emit WILL_SUBMIT_ONCE. I don't know, I'm not sure I am
after the same analysis as Walter was when he did OnFormSubmitted... I guess I
could add it for parity? 

[Ilya Sherman, 2015/03/23 23:58:17]

I defer to Walter and Evan, but it does seem likely that the same data would be
useful for AJAX-powered forms as for others.

+}
+
+void AutofillMetrics::FormEventLogger::OnFormSubmitted() {
+  // Not logging this kind of form if we haven't logged a user interaction.
+  if (!has_logged_interacted_)
+    return;
 
   // Not logging twice.
   if (has_logged_submitted_)
     return;
   has_logged_submitted_ = true;
 
   if (!has_logged_suggestion_filled_) {
     Log(AutofillMetrics::FORM_EVENT_NO_SUGGESTION_SUBMITTED_ONCE);
   } else if (logged_suggestion_filled_was_masked_server_card_) {
     Log(AutofillMetrics
@@ skipping 22 matching lines @@
   else if (is_server_data_available_ && !is_local_data_available_)
     name += ".WithOnlyServerData";
   else if (!is_server_data_available_ && is_local_data_available_)
     name += ".WithOnlyLocalData";
   else
     name += ".WithBothServerAndLocalData";
   LogUMAHistogramEnumeration(name, event, NUM_FORM_EVENTS);
 }
 
 }  // namespace autofill