Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1010253003: Updating documentation (Closed)

Created:
5 years, 9 months ago by lfg
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating documentation. This CL adds the embedderId parameter to appview documentation. Committed: https://crrev.com/09aa4bc1faacc17768f5e8fd4798ac0fb61c3b4b Cr-Commit-Position: refs/heads/master@{#321458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/common/extensions/api/appview_tag.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
lfg
PTAL, thanks!
5 years, 9 months ago (2015-03-19 21:50:38 UTC) #2
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-19 21:53:41 UTC) #3
lfg
Hi Ken, please take a look.
5 years, 9 months ago (2015-03-19 22:10:18 UTC) #5
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-19 22:16:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010253003/1
5 years, 9 months ago (2015-03-19 22:18:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 22:50:03 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:50:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09aa4bc1faacc17768f5e8fd4798ac0fb61c3b4b
Cr-Commit-Position: refs/heads/master@{#321458}

Powered by Google App Engine
This is Rietveld 408576698