Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1010213006: [Files.app] Add a test to check tabfocus (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] Add a test to check tabfocus This patch adds tests of transition of tabfocus in Files.app. BUG=469061 Committed: https://crrev.com/956dde61ed47e00ee40ac6c78f99bfcab7fe4d97 Cr-Commit-Position: refs/heads/master@{#321957}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Fix a test failure #

Patch Set 4 : Fix test failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -23 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/test_util_base.js View 1 2 2 chunks +60 lines, -21 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/banners.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/tab_index.js View 1 2 3 2 chunks +104 lines, -2 lines 0 comments Download
M ui/file_manager/integration_tests/remote_call.js View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
yoshiki
fukino-san, PTAL. Thanks.
5 years, 9 months ago (2015-03-20 02:08:09 UTC) #3
yoshiki
fukino-san, PTAL. Thanks.
5 years, 9 months ago (2015-03-20 02:08:11 UTC) #4
fukino
lgtm. Thank you!
5 years, 9 months ago (2015-03-20 05:45:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010213006/40001
5 years, 9 months ago (2015-03-20 06:59:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/38167)
5 years, 9 months ago (2015-03-20 08:32:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010213006/60001
5 years, 9 months ago (2015-03-23 04:54:15 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/38563)
5 years, 9 months ago (2015-03-23 06:11:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010213006/80001
5 years, 9 months ago (2015-03-24 08:23:30 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 9 months ago (2015-03-24 08:55:45 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 08:56:13 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/956dde61ed47e00ee40ac6c78f99bfcab7fe4d97
Cr-Commit-Position: refs/heads/master@{#321957}

Powered by Google App Engine
This is Rietveld 408576698