Source/core/layout/LayoutGrid.h - Issue 1010213002: [CSS Grid Layout] Support marking tracks as infinitely growable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutGrid.h

Issue 1010213002: [CSS Grid Layout] Support marking tracks as infinitely growable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased against master. Using new templatized methods. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/mark-as-infinitely-growable.html ('K') | « LayoutTests/fast/css-grid-layout/mark-as-infinitely-growable-expected.txt ('k') | Source/core/layout/LayoutGrid.cpp » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutGrid.h

diff --git a/Source/core/layout/LayoutGrid.h b/Source/core/layout/LayoutGrid.h

index 0a50e9c3763348c7ed68f6a273f16c398803aee3..175aec756649a70d77aa3dbc39434b2f061efc90 100644

--- a/Source/core/layout/LayoutGrid.h

+++ b/Source/core/layout/LayoutGrid.h

@@ -90,8 +90,6 @@ public:

}

private:

- typedef void (GridTrack::* AccumulatorGrowFunction)(LayoutUnit);

virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectLayoutGrid || LayoutBlock::isOfType(type); }

virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const override;

virtual void computePreferredLogicalWidths() override;