LayoutTests/fast/css-grid-layout/mark-as-infinitely-growable.html - Issue 1010213002: [CSS Grid Layout] Support marking tracks as infinitely growable

Side by Side Diff: LayoutTests/fast/css-grid-layout/mark-as-infinitely-growable.html

Issue 1010213002: [CSS Grid Layout] Support marking tracks as infinitely growable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased against master. Using new templatized methods. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <head>

	3 <link href="resources/grid.css" rel="stylesheet"/>

	4 <style>

	5 .grid {

	6 font: 10px/1 Ahem;

	7 }

	8 .gridAutoAndAuto {

	9 grid-template-columns: auto auto;

	10 }

	11

	12 .gridFixedMaxContentAndFixedMaxContent {

	13 grid-template-columns: minmax(20px, max-content) minmax(10px, max-content);

	14 }

	15 </style>

	16 <script src="../../resources/js-test.js"></script>

	17 </head>

	18 <body>

	19 <script src="resources/grid-definitions-parsing-utils.js"></script>

	20

	21 <div class="grid gridAutoAndAuto" id="gridAutoAndAuto">

	22 <div class="firstRowFirstColumn">X</div>

	23 <div class="firstRowBothColumn">XXXXXX XXX</div>
	Manuel Rego 2015/06/26 11:09:47 I guess that both items are in the first row is no I guess that both items are in the first row is not needed. Not really important but on a first sight, it's a bit weird that we're placing both items overlapped. svillar 2015/06/29 07:08:27 Why weird? The behavior is exactly the same, the a Show quoted text On 2015/06/26 11:09:47, Manuel Rego wrote: > I guess that both items are in the first row is not needed. > Not really important but on a first sight, it's a bit weird > that we're placing both items overlapped. Why weird? The behavior is exactly the same, the algorithm does not take into account that so. Manuel Rego 2015/06/29 07:46:42 I mean weird from an outsider point of view, that I mean weird from an outsider point of view, that might think that this is a condition for this specific case. Also if you open the HTML in the content_shell won't see it very easily. Anyway, not important at all, so feel free to keep it as it is.
	24 </div>

	25

	26 <div class="grid gridFixedMaxContentAndFixedMaxContent" id="gridFixedMaxContentA ndFixedMaxContent">

	27 <div class="firstRowFirstColumn">XX</div>
	Manuel Rego 2015/06/26 11:09:47 Wouldn't be better to have just one "X" here? That Wouldn't be better to have just one "X" here? That way we could check that the "20px" from minmax() is actually being considered. The result would be the same "20px 80px". svillar 2015/06/29 07:08:27 Well this is test was made to check the infinitely Show quoted text On 2015/06/26 11:09:47, Manuel Rego wrote: > Wouldn't be better to have just one "X" here? > That way we could check that the "20px" from minmax() > is actually being considered. > > The result would be the same "20px 80px". Well this is test was made to check the infinitely growable part of the algorithm, what you're suggesting is to also check the code that initializes the used breadths something that IMO is out of scope (almost all the test will fail in that case). Anyway I can change it. Manuel Rego 2015/06/29 07:46:42 Yeah, it's not related to this maybe you can've bo Yeah, it's not related to this maybe you can've both tests with 1 and 2 "X". It's always good to increase coverage :-) Anyway, do whatever you think is better.
	28 <div class="firstRowBothColumn">XXXX X XXX</div>

	29 </div>

	30

	31 <script>

	32 testGridDefinitionsValues(gridAutoAndAuto, "10px 90px", "10px");

	33 testGridDefinitionsValues(gridFixedMaxContentAndFixedMaxContent, "20px 80px", "1 0px");

	34 </script>

	35

	36 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/mark-as-infinitely-growable-expected.txt » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')