Source/core/page/SpatialNavigation.cpp - Issue 1010203002: Avoid computing navigation data for nodes in the wrong navigation direction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/SpatialNavigation.cpp

Issue 1010203002: Avoid computing navigation data for nodes in the wrong navigation direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/SpatialNavigation.cpp

diff --git a/Source/core/page/SpatialNavigation.cpp b/Source/core/page/SpatialNavigation.cpp

index 952bfd7e0bf67e00b45727706b915133692fd314..bfa98d56efe06b4acaa0e220128094d9aab6e0c6 100644

--- a/Source/core/page/SpatialNavigation.cpp

+++ b/Source/core/page/SpatialNavigation.cpp

@@ -124,7 +124,7 @@ static inline bool rightOf(const LayoutRect& a, const LayoutRect& b)

|| (a.x() >= b.x() && a.maxX() > b.maxX() && a.y() < b.maxY() && a.maxY() > b.y());

}

-static bool isRectInDirection(WebFocusType type, const LayoutRect& curRect, const LayoutRect& targetRect)

+bool isRectInDirection(WebFocusType type, const LayoutRect& curRect, const LayoutRect& targetRect)

{

switch (type) {

case WebFocusTypeLeft:

« Source/core/page/FocusController.cpp ('K') | « Source/core/page/SpatialNavigation.h ('k') | no next file » | no next file with comments »