Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: Source/core/page/FocusController.cpp

Issue 1010203002: Avoid computing navigation data for nodes in the wrong navigation direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/SpatialNavigation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/FocusController.cpp
diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp
index 70c57737cdf428487ab7a45539803ea77e9d5971..dad85c5722bb649e90441c1bedcd0814489d355b 100644
--- a/Source/core/page/FocusController.cpp
+++ b/Source/core/page/FocusController.cpp
@@ -886,6 +886,9 @@ void FocusController::findFocusCandidateInContainer(Node& container, const Layou
if (candidate.isNull())
continue;
+ if (!isRectInDirection(type, current.rect, candidate.rect))
fs 2015/03/18 14:02:11 Could you perhaps make this the first thing in dis
Abhijeet Kandalkar Slow 2015/03/18 14:26:42 Done.
+ continue;
+
candidate.enclosingScrollableBox = &container;
updateFocusCandidateIfNeeded(type, current, candidate, closest);
}
« no previous file with comments | « no previous file | Source/core/page/SpatialNavigation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698