Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1010203002: Avoid computing navigation data for nodes in the wrong navigation direction (Closed)

Created:
5 years, 9 months ago by Abhijeet Kandalkar Slow
Modified:
5 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid computing navigation data for nodes in the wrong navigation direction Spatial Navigation should consider only those nodes as candidate which are exactly in the focus-direction. This implementation apply early stage detection of probable candidate to avoid unwanted calculation. BUG=467864 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192165

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/page/SpatialNavigation.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
Abhijeet Kandalkar Slow
Please review patch
5 years, 9 months ago (2015-03-17 10:21:02 UTC) #2
c.shu
On 2015/03/17 10:21:02, Abhijeet Kandalkar wrote: > Please review patch Please add layout tests to ...
5 years, 9 months ago (2015-03-17 14:17:47 UTC) #3
c.shu
On 2015/03/17 14:17:47, c.shu wrote: > On 2015/03/17 10:21:02, Abhijeet Kandalkar wrote: > > Please ...
5 years, 9 months ago (2015-03-17 14:20:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010203002/1
5 years, 9 months ago (2015-03-18 10:28:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/29252)
5 years, 9 months ago (2015-03-18 10:49:11 UTC) #8
Abhijeet Kandalkar Slow
Hi fs/philip Could you please review patch.
5 years, 9 months ago (2015-03-18 11:16:38 UTC) #10
fs
Please fix you description so that it's on the form: My subject (short description) <blank ...
5 years, 9 months ago (2015-03-18 14:02:11 UTC) #11
Abhijeet Kandalkar Slow
On 2015/03/18 14:02:11, fs wrote: > Please fix you description so that it's on the ...
5 years, 9 months ago (2015-03-18 14:06:47 UTC) #12
fs
On 2015/03/18 14:06:47, Abhijeet Kandalkar wrote: > On 2015/03/18 14:02:11, fs wrote: > > Please ...
5 years, 9 months ago (2015-03-18 14:15:45 UTC) #13
Abhijeet Kandalkar Slow
Updated as per review comments. https://codereview.chromium.org/1010203002/diff/1/Source/core/page/FocusController.cpp File Source/core/page/FocusController.cpp (right): https://codereview.chromium.org/1010203002/diff/1/Source/core/page/FocusController.cpp#newcode889 Source/core/page/FocusController.cpp:889: if (!isRectInDirection(type, current.rect, candidate.rect)) ...
5 years, 9 months ago (2015-03-18 14:26:42 UTC) #14
fs
https://codereview.chromium.org/1010203002/diff/20001/Source/core/page/SpatialNavigation.cpp File Source/core/page/SpatialNavigation.cpp (right): https://codereview.chromium.org/1010203002/diff/20001/Source/core/page/SpatialNavigation.cpp#newcode508 Source/core/page/SpatialNavigation.cpp:508: if (!isRectInDirection(type, currentRect, nodeRect)) This won't compile. https://codereview.chromium.org/1010203002/diff/20001/Source/core/page/SpatialNavigation.cpp#newcode520 Source/core/page/SpatialNavigation.cpp:520: ...
5 years, 9 months ago (2015-03-18 14:36:15 UTC) #15
Abhijeet Kandalkar Slow
Updated patch for review. https://codereview.chromium.org/1010203002/diff/20001/Source/core/page/SpatialNavigation.cpp File Source/core/page/SpatialNavigation.cpp (right): https://codereview.chromium.org/1010203002/diff/20001/Source/core/page/SpatialNavigation.cpp#newcode508 Source/core/page/SpatialNavigation.cpp:508: if (!isRectInDirection(type, currentRect, nodeRect)) On ...
5 years, 9 months ago (2015-03-19 06:09:42 UTC) #16
fs
lgtm
5 years, 9 months ago (2015-03-19 09:51:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010203002/40001
5 years, 9 months ago (2015-03-19 09:54:12 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:18:03 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192165

Powered by Google App Engine
This is Rietveld 408576698