ui/file_manager/file_manager/foreground/js/file_transfer_controller.js - Issue 1010163002: Files.app: Fix closure error which will raised by the updated compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_transfer_controller.js

Issue 1010163002: Files.app: Fix closure error which will raised by the updated compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Define FakeEntry record type and use it. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/file_manager_commands.js ('k') | ui/file_manager/file_manager/foreground/js/file_watcher.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/file_transfer_controller.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js b/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js

index f5e179223b7d36eaee44acce2dfe7c4b657bed1a..8623009e34ee1bb4fec290f3e8c3cd98bc627fe8 100644

--- a/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js

+++ b/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js

@@ -482,7 +482,8 @@ FileTransferController.prototype.paste =

(!util.isDropEffectAllowed(effectAllowed, 'copy') ||

opt_effect === 'move');

var destinationEntry =

- opt_destinationEntry || this.directoryModel_.getCurrentDirEntry();

+ opt_destinationEntry ||

+ /** @type {DirectoryEntry} */ (this.directoryModel_.getCurrentDirEntry());

var entries = [];

var failureUrls;

var taskId = this.fileOperationManager_.generateTaskId();

@@ -850,7 +851,8 @@ FileTransferController.prototype.onDrop_ =

if (!this.canPasteOrDrop_(event.dataTransfer, destinationEntry))

return;

event.preventDefault();

- this.paste(event.dataTransfer, destinationEntry,

+ this.paste(event.dataTransfer,

+ /** @type {DirectoryEntry} */ (destinationEntry),

this.selectDropEffect_(event, destinationEntry));

this.clearDropTarget_();

};

@@ -1055,7 +1057,7 @@ FileTransferController.prototype.onBeforePaste_ = function(event) {

/**

* @param {!ClipboardData} clipboardData Clipboard data object.

- * @param {DirectoryEntry} destinationEntry Destination entry.

+ * @param {DirectoryEntry|FakeEntry} destinationEntry Destination entry.

* @return {boolean} Returns true if items stored in {@code clipboardData} can

* be pasted to {@code destinationEntry}. Otherwise, returns false.

* @private

@@ -1175,7 +1177,7 @@ FileTransferController.prototype.onFileSelectionChangedThrottled_ = function() {

/**

* @param {!Event} event Drag event.

- * @param {DirectoryEntry} destinationEntry Destination entry.

+ * @param {DirectoryEntry|FakeEntry} destinationEntry Destination entry.

* @return {string} Returns the appropriate drop query type ('none', 'move'

* or copy') to the current modifiers status and the destination.

* @private