Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: ui/file_manager/file_manager/common/js/util.js

Issue 1010163002: Files.app: Fix closure error which will raised by the updated compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Define FakeEntry record type and use it. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/common/js/util.js
diff --git a/ui/file_manager/file_manager/common/js/util.js b/ui/file_manager/file_manager/common/js/util.js
index ff3428378107d5b70569dd31a0dc58bea812452e..8443e32fd590c15121e4559a0f873978b4e8a1a7 100644
--- a/ui/file_manager/file_manager/common/js/util.js
+++ b/ui/file_manager/file_manager/common/js/util.js
@@ -589,7 +589,7 @@ Object.freeze(util.EntryChangedKind);
/**
* Obtains whether an entry is fake or not.
- * @param {(!Entry|!Object)} entry Entry or a fake entry.
+ * @param {(!Entry|!FakeEntry)} entry Entry or a fake entry.
* @return {boolean} True if the given entry is fake.
*/
util.isFakeEntry = function(entry) {
@@ -633,8 +633,8 @@ util.UserDOMError.prototype = {
/**
* Compares two entries.
- * @param {Entry|Object} entry1 The entry to be compared. Can be a fake.
- * @param {Entry|Object} entry2 The entry to be compared. Can be a fake.
+ * @param {Entry|FakeEntry} entry1 The entry to be compared. Can be a fake.
+ * @param {Entry|FakeEntry} entry2 The entry to be compared. Can be a fake.
* @return {boolean} True if the both entry represents a same file or
* directory. Returns true if both entries are null.
*/
@@ -692,7 +692,7 @@ util.comparePath = function(entry1, entry2) {
* Checks if {@code entry} is an immediate child of {@code directory}.
*
* @param {Entry} entry The presumptive child.
- * @param {DirectoryEntry} directory The presumptive parent.
+ * @param {DirectoryEntry|FakeEntry} directory The presumptive parent.
* @return {!Promise.<boolean>} Resolves with true if {@code directory} is
* parent of {@code entry}.
*/
@@ -715,9 +715,9 @@ util.isChildEntry = function(entry, directory) {
* Checks if the child entry is a descendant of another entry. If the entries
* point to the same file or directory, then returns false.
*
- * @param {!DirectoryEntry|!Object} ancestorEntry The ancestor directory entry.
- * Can be a fake.
- * @param {!Entry|!Object} childEntry The child entry. Can be a fake.
+ * @param {!DirectoryEntry|!FakeEntry} ancestorEntry The ancestor directory
+ * entry. Can be a fake.
+ * @param {!Entry|!FakeEntry} childEntry The child entry. Can be a fake.
* @return {boolean} True if the child entry is contained in the ancestor path.
*/
util.isDescendantEntry = function(ancestorEntry, childEntry) {

Powered by Google App Engine
This is Rietveld 408576698