chrome/browser/chromeos/extensions/wallpaper_private_api.cc - Issue 101013002: Make sure WindowObservers are removed from window before destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_private_api.cc

Issue 101013002: Make sure WindowObservers are removed from window before destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix shutdown order Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/wallpaper_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc b/chrome/browser/chromeos/extensions/wallpaper_private_api.cc

index f58be4ce7e4413bb9db225b934917bfe46223861..4624b6d1cd92e0c44e6ad849b26d6faf8660e5a0 100644

--- a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc

+++ b/chrome/browser/chromeos/extensions/wallpaper_private_api.cc

@@ -222,8 +222,6 @@ void WindowStateManager::RemoveObserverIfUnreferenced(aura::Window* window) {

}

void WindowStateManager::OnWindowDestroyed(aura::Window* window) {

- window->RemoveObserver(this);

for (UserIDHashWindowListMap::iterator iter =

user_id_hash_window_list_map_.begin();

iter != user_id_hash_window_list_map_.end();