ash/wm/window_cycle_list.cc - Issue 101013002: Make sure WindowObservers are removed from window before destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/window_cycle_list.cc

Issue 101013002: Make sure WindowObservers are removed from window before destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix shutdown order Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/window_cycle_list.cc

diff --git a/ash/wm/window_cycle_list.cc b/ash/wm/window_cycle_list.cc

index 428804f66f0d14e3c576facd2194ff5a7b7db80f..d6bf24a59cc3c6abad860b695577844564cb86c5 100644

--- a/ash/wm/window_cycle_list.cc

+++ b/ash/wm/window_cycle_list.cc

@@ -72,8 +72,6 @@ int WindowCycleList::GetWindowIndex(aura::Window* window) {

}

void WindowCycleList::OnWindowDestroyed(aura::Window* window) {

- window->RemoveObserver(this);

WindowList::iterator i = std::find(windows_.begin(), windows_.end(), window);

DCHECK(i != windows_.end());

int removed_index = static_cast<int>(i - windows_.begin());

« no previous file with comments | « ash/wm/solo_window_tracker_unittest.cc ('k') | ash/wm/window_state.h » ('j') | no next file with comments »