Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: ash/drag_drop/drag_drop_controller.cc

Issue 101013002: Make sure WindowObservers are removed from window before destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix shutdown order Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/shell.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/drag_drop/drag_drop_controller.cc
diff --git a/ash/drag_drop/drag_drop_controller.cc b/ash/drag_drop/drag_drop_controller.cc
index 07ab4f39337690f7340edd4d2ce3f2ee6fe5c9cd..1d5d636347eb68d768b6b593e833be773ef39417 100644
--- a/ash/drag_drop/drag_drop_controller.cc
+++ b/ash/drag_drop/drag_drop_controller.cc
@@ -461,14 +461,10 @@ void DragDropController::OnGestureEvent(ui::GestureEvent* event) {
}
void DragDropController::OnWindowDestroyed(aura::Window* window) {
- if (drag_window_ == window) {
- drag_window_->RemoveObserver(this);
+ if (drag_window_ == window)
drag_window_ = NULL;
- }
- if (drag_source_window_ == window) {
- drag_source_window_->RemoveObserver(this);
+ if (drag_source_window_ == window)
drag_source_window_ = NULL;
- }
}
////////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « no previous file | ash/shell.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698