ui/aura/client/default_activation_client.cc - Issue 101013002: Make sure WindowObservers are removed from window before destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/client/default_activation_client.cc

Issue 101013002: Make sure WindowObservers are removed from window before destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/client/default_activation_client.cc

diff --git a/ui/aura/client/default_activation_client.cc b/ui/aura/client/default_activation_client.cc

index 629f12ad2dda3750393f54e8fac3f937cb348e72..ccb660b81f45615486f3d1786538c8dd839d71c5 100644

--- a/ui/aura/client/default_activation_client.cc

+++ b/ui/aura/client/default_activation_client.cc

@@ -102,7 +102,6 @@ void DefaultActivationClient::OnWindowDestroyed(Window* window) {

last_active_ = NULL;

if (window == GetActiveWindow()) {

- window->RemoveObserver(this);

active_windows_.pop_back();

Window* next_active = GetActiveWindow();

if (next_active && aura::client::GetActivationChangeObserver(next_active)) {