Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: ash/wm/window_state.cc

Issue 101013002: Make sure WindowObservers are removed from window before destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/window_state.cc
diff --git a/ash/wm/window_state.cc b/ash/wm/window_state.cc
index e29b9642f5f6d0022f1a7d24da212827df292e8f..01b68316ef3925a5c26ea6d112b845ab4399ffad 100644
--- a/ash/wm/window_state.cc
+++ b/ash/wm/window_state.cc
@@ -279,10 +279,6 @@ void WindowState::OnWindowPropertyChanged(aura::Window* window,
}
}
-void WindowState::OnWindowDestroying(aura::Window* window) {
- window_->RemoveObserver(this);
-}
-
void WindowState::SnapWindow(WindowShowType left_or_right,
const gfx::Rect& bounds) {
// Compute the bounds that the window will restore to. If the window does not

Powered by Google App Engine
This is Rietveld 408576698