Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: ui/aura/window_observer.h

Issue 101013002: Make sure WindowObservers are removed from window before destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cc Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/window.h ('k') | ui/aura/window_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window_observer.h
diff --git a/ui/aura/window_observer.h b/ui/aura/window_observer.h
index 5008ac514d50724cc1b924c07609e8ca015459dd..e4a4615ac30843d021ea121a209f1b9a2457046a 100644
--- a/ui/aura/window_observer.h
+++ b/ui/aura/window_observer.h
@@ -89,7 +89,9 @@ class AURA_EXPORT WindowObserver {
// Invoked when the Window has been destroyed (i.e. at the end of its
// destructor). This is called after the window is removed from its parent.
- virtual void OnWindowDestroyed(Window* window) {}
+ // The default implementation simply remove itself from |window|'s observer
sky 2013/12/04 04:27:32 If we're going to do this, then we should follow t
+ // list.
+ virtual void OnWindowDestroyed(Window* window);
// Called when a Window has been added to a RootWindow.
virtual void OnWindowAddedToRootWindow(Window* window) {}
« no previous file with comments | « ui/aura/window.h ('k') | ui/aura/window_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698