Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: ash/wm/window_state.h

Issue 101013002: Make sure WindowObservers are removed from window before destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix shutdown order Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ash/wm/window_cycle_list.cc ('k') | ash/wm/window_state.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_WM_WINDOW_STATE_H_ 5 #ifndef ASH_WM_WINDOW_STATE_H_
6 #define ASH_WM_WINDOW_STATE_H_ 6 #define ASH_WM_WINDOW_STATE_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "ash/wm/wm_types.h" 9 #include "ash/wm/wm_types.h"
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 return window_resizer_; 241 return window_resizer_;
242 } 242 }
243 void set_window_resizer_(WindowResizer* window_resizer) { 243 void set_window_resizer_(WindowResizer* window_resizer) {
244 window_resizer_ = window_resizer; 244 window_resizer_ = window_resizer;
245 } 245 }
246 246
247 // aura::WindowObserver overrides: 247 // aura::WindowObserver overrides:
248 virtual void OnWindowPropertyChanged(aura::Window* window, 248 virtual void OnWindowPropertyChanged(aura::Window* window,
249 const void* key, 249 const void* key,
250 intptr_t old) OVERRIDE; 250 intptr_t old) OVERRIDE;
251 virtual void OnWindowDestroying(aura::Window* window) OVERRIDE;
252 251
253 private: 252 private:
254 // Snaps the window to left or right of the desktop with given bounds. 253 // Snaps the window to left or right of the desktop with given bounds.
255 void SnapWindow(WindowShowType left_or_right, 254 void SnapWindow(WindowShowType left_or_right,
256 const gfx::Rect& bounds); 255 const gfx::Rect& bounds);
257 256
258 // The owner of this window settings. 257 // The owner of this window settings.
259 aura::Window* window_; 258 aura::Window* window_;
260 scoped_ptr<WindowStateDelegate> delegate_; 259 scoped_ptr<WindowStateDelegate> delegate_;
261 260
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 ASH_EXPORT WindowState* GetWindowState(aura::Window* window); 294 ASH_EXPORT WindowState* GetWindowState(aura::Window* window);
296 295
297 // const version of GetWindowState. 296 // const version of GetWindowState.
298 ASH_EXPORT const WindowState* 297 ASH_EXPORT const WindowState*
299 GetWindowState(const aura::Window* window); 298 GetWindowState(const aura::Window* window);
300 299
301 } // namespace wm 300 } // namespace wm
302 } // namespace ash 301 } // namespace ash
303 302
304 #endif // ASH_WM_WINDOW_STATE_H_ 303 #endif // ASH_WM_WINDOW_STATE_H_
OLDNEW
« no previous file with comments | « ash/wm/window_cycle_list.cc ('k') | ash/wm/window_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698