Add GrRenderTarget parameter to GrTextContext::canDraw

src/gpu/GrTextContext.cpp

 /*
  * Copyright 2010 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrTextContext.h"
 #include "GrContext.h"
 #include "GrDrawTarget.h"
@@ skipping 27 matching lines @@
 
 bool GrTextContext::drawText(GrRenderTarget* rt, const GrClip& clip, const GrPaint& paint,
                              const SkPaint& skPaint, const SkMatrix& viewMatrix,
                              const char text[], size_t byteLength,
                              SkScalar x, SkScalar y) {
     if (!fContext->getTextTarget()) {
         return false;
     }
 
     GrTextContext* textContext = this;
     do {

[vbuzinov, 2015/03/17 13:06:56]

Can we create a pipeline builder here and pass it to canDraw instead of rt (rt
can be queried with getRenderTarget)?  That would allow us to just use the same
code in canDraw as in GrStencilAndCoverPathRenderer.  

We could then pass it to onDrawText as well to the implementation that can draw.
 Unless its creation has to be deferred until later for some reason?

[bsalomon, 2015/03/17 14:45:48]

I like that direction (passing a PB here). I know there were some complexities
that caused us to pass both a SkPaint and GrPaint here. IIRC it is related to
LCD text. The XP work was supposed to help simplify that. It'd be great to just
turn the GrPaint into a GrPB here and drop the two paints. But I'm not familiar
with the details. Adding Greg and Jim to comment.

-        if (textContext->canDraw(skPaint, viewMatrix)) {
+        if (textContext->canDraw(rt, skPaint, viewMatrix)) {
             textContext->onDrawText(rt, clip, paint, skPaint, viewMatrix, text, byteLength, x, y);
             return true;
         }
         textContext = textContext->fFallbackTextContext;
     } while (textContext);
 
     return false;
 }
 
 bool GrTextContext::drawPosText(GrRenderTarget* rt, const GrClip& clip, const GrPaint& paint,
                                 const SkPaint& skPaint, const SkMatrix& viewMatrix,
                                 const char text[], size_t byteLength,
                                 const SkScalar pos[], int scalarsPerPosition,
                                 const SkPoint& offset) {
     if (!fContext->getTextTarget()) {
         return false;
     }
 
     GrTextContext* textContext = this;
     do {
-        if (textContext->canDraw(skPaint, viewMatrix)) {
+        if (textContext->canDraw(rt, skPaint, viewMatrix)) {
             textContext->onDrawPosText(rt, clip, paint, skPaint, viewMatrix, text, byteLength, pos,
                                        scalarsPerPosition, offset);
             return true;
         }
         textContext = textContext->fFallbackTextContext;
     } while (textContext);
 
     return false;
 }
 
@@ skipping 35 matching lines @@
     if (cache->getAuxProcData(GlyphCacheAuxProc, &auxData)) {
         scaler = (GrFontScaler*)auxData;
     }
     if (NULL == scaler) {
         scaler = SkNEW_ARGS(GrFontScaler, (cache));
         cache->setAuxProc(GlyphCacheAuxProc, scaler);
     }
 
     return scaler;
 }