Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1010083008: [Extensions] Replace the developer_private.js extern with the autogenerated one (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Replace the developer_private.js extern with the autogenerated one Automatic extern generation has gotten to the point where it yields a better result than the somewhat hand-modified version (Yay!). Use the generated one in the closure compiler externs. BUG=469920 Committed: https://crrev.com/5ed4724796d73dde8d2881181fc480d7f087f6bd Cr-Commit-Position: refs/heads/master@{#322672}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -125 lines) Patch
M chrome/common/extensions/api/developer_private.idl View 1 2 chunks +18 lines, -12 lines 0 comments Download
M third_party/closure_compiler/externs/developer_private.js View 1 22 chunks +117 lines, -113 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Devlin
5 years, 9 months ago (2015-03-26 20:29:43 UTC) #2
Dan Beam
¡lgtm! https://codereview.chromium.org/1010083008/diff/1/third_party/closure_compiler/externs/developer_private.js File third_party/closure_compiler/externs/developer_private.js (right): https://codereview.chromium.org/1010083008/diff/1/third_party/closure_compiler/externs/developer_private.js#newcode264 third_party/closure_compiler/externs/developer_private.js:264: * runtime_errors: !Array<*>, :_( https://codereview.chromium.org/1010083008/diff/1/third_party/closure_compiler/externs/developer_private.js#newcode416 third_party/closure_compiler/externs/developer_private.js:416: * @param ...
5 years, 9 months ago (2015-03-26 20:36:00 UTC) #3
Devlin
https://codereview.chromium.org/1010083008/diff/1/third_party/closure_compiler/externs/developer_private.js File third_party/closure_compiler/externs/developer_private.js (right): https://codereview.chromium.org/1010083008/diff/1/third_party/closure_compiler/externs/developer_private.js#newcode264 third_party/closure_compiler/externs/developer_private.js:264: * runtime_errors: !Array<*>, On 2015/03/26 20:36:00, Dan Beam wrote: ...
5 years, 9 months ago (2015-03-26 22:36:36 UTC) #4
Devlin
https://codereview.chromium.org/1010083008/diff/1/third_party/closure_compiler/externs/developer_private.js File third_party/closure_compiler/externs/developer_private.js (right): https://codereview.chromium.org/1010083008/diff/1/third_party/closure_compiler/externs/developer_private.js#newcode487 third_party/closure_compiler/externs/developer_private.js:487: * folder. On 2015/03/26 22:36:36, Devlin wrote: > On ...
5 years, 9 months ago (2015-03-27 23:16:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010083008/40001
5 years, 9 months ago (2015-03-27 23:17:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-27 23:20:43 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 23:21:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ed4724796d73dde8d2881181fc480d7f087f6bd
Cr-Commit-Position: refs/heads/master@{#322672}

Powered by Google App Engine
This is Rietveld 408576698