Implement AtkComponent interface for chrome UI.

ui/accessibility/platform/ax_platform_node_auralinux.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/accessibility/platform/ax_platform_node_auralinux.h"
 
 #include "base/command_line.h"
 #include "base/strings/sys_string_conversions.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/accessibility/platform/atk_util_auralinux.h"
@@ skipping 165 matching lines @@
 
   AtkStateSet* atk_state_set =
       ATK_OBJECT_CLASS(ax_platform_node_auralinux_parent_class)->
       ref_state_set(atk_object);
 
   obj->GetAtkState(atk_state_set);
   return atk_state_set;
 }
 
 //
+// AtkComponent interface
+//
+
+static void ax_platform_node_auralinux_get_extents(AtkComponent* atk_component,
+                                               gint* x, gint* y,
+                                               gint* width, gint* height,
+                                               AtkCoordType coord_type) {
+  *x = *y = *width = *height = 0;
+  AtkObject* atk_object = ATK_OBJECT(atk_component);
+  ui::AXPlatformNodeAuraLinux* obj =
+      AtkObjectToAXPlatformNodeAuraLinux(atk_object);
+  if (!obj)
+    return;
+
+  obj->GetExtents(x, y, width, height, coord_type);
+}
+
+static void ax_platform_node_auralinux_get_position(AtkComponent* atk_component,
+                                                gint* x, gint* y,
+                                                AtkCoordType coord_type) {
+  *x = *y = 0;
+  AtkObject* atk_object = ATK_OBJECT(atk_component);
+  ui::AXPlatformNodeAuraLinux* obj =
+      AtkObjectToAXPlatformNodeAuraLinux(atk_object);
+  if (!obj)
+    return;
+
+  obj->GetPosition(x, y, coord_type);
+}
+
+static void ax_platform_node_auralinux_get_size(AtkComponent* atk_component,
+                                            gint* width, gint* height) {
+  *width = *height = 0;
+  AtkObject* atk_object = ATK_OBJECT(atk_component);
+  ui::AXPlatformNodeAuraLinux* obj =
+      AtkObjectToAXPlatformNodeAuraLinux(atk_object);
+  if (!obj)
+    return;
+
+  obj->GetSize(width, height);
+}
+
+void ax_component_interface_base_init(AtkComponentIface* iface) {
+  iface->get_extents = ax_platform_node_auralinux_get_extents;
+  iface->get_position = ax_platform_node_auralinux_get_position;
+  iface->get_size = ax_platform_node_auralinux_get_size;
+}
+
+static const GInterfaceInfo ComponentInfo = {
+  reinterpret_cast<GInterfaceInitFunc>(ax_component_interface_base_init), 0, 0
+};
+
+//
 // The rest of the AXPlatformNodeAuraLinux code, not specific to one
 // of the Atk* interfaces.
 //
 
 static void ax_platform_node_auralinux_init(AtkObject* atk_object,
                                             gpointer data) {
   if (ATK_OBJECT_CLASS(ax_platform_node_auralinux_parent_class)->initialize) {
     ATK_OBJECT_CLASS(ax_platform_node_auralinux_parent_class)->initialize(
         atk_object, data);
   }
@@ skipping 36 matching lines @@
       (GClassFinalizeFunc) 0,
       0, /* class data */
       sizeof(AXPlatformNodeAuraLinuxObject), /* instance size */
       0, /* nb preallocs */
       (GInstanceInitFunc) 0,
       0 /* value table */
     };
 
     GType type = g_type_register_static(
         ATK_TYPE_OBJECT, "AXPlatformNodeAuraLinux", &tinfo, GTypeFlags(0));
+    g_type_add_interface_static(type, ATK_TYPE_COMPONENT, &ComponentInfo);
     g_once_init_leave(&type_volatile, type);
   }
 
   return type_volatile;
 }
 
 AXPlatformNodeAuraLinuxObject* ax_platform_node_auralinux_new(
     ui::AXPlatformNodeAuraLinux* obj) {
   #if !GLIB_CHECK_VERSION(2, 36, 0)
   static bool first_time = true;
@@ skipping 133 matching lines @@
   return atk_object_;
 }
 
 void AXPlatformNodeAuraLinux::NotifyAccessibilityEvent(ui::AXEvent event_type) {
 }
 
 int AXPlatformNodeAuraLinux::GetIndexInParent() {
   return 0;
 }
 
+void AXPlatformNodeAuraLinux::GetExtents(gint* x, gint* y,
+                                         gint* width, gint* height,
+                                         AtkCoordType coord_type) {
+  gfx::Rect extents = GetBoundsInScreen();
+
+  *x = extents.x();
+  *y = extents.y();
+  *width = extents.width();
+  *height = extents.height();
+
+  if (coord_type == ATK_XY_WINDOW) {
+    gfx::Rect window_coords = GetWindowCoords();
+    *x -= window_coords.x();
+    *y -= window_coords.y();
+  }
+}
+
+void AXPlatformNodeAuraLinux::GetPosition(gint* x, gint* y,
+                                          AtkCoordType coord_type) {
+  gfx::Rect rect_pos = GetBoundsInScreen();
+
+  *x = rect_pos.x();
+  *y = rect_pos.y();
+
+  if (coord_type == ATK_XY_WINDOW) {
+    gfx::Rect window_coords = GetWindowCoords();
+    *x -= window_coords.x();
+    *y -= window_coords.y();
+  }
+}
+
+void AXPlatformNodeAuraLinux::GetSize(gint* width, gint* height) {
+  gfx::Rect rect_size = GetData().location;

[shreeramk, 2015/03/31 14:47:10]

I think better would be to move this calculations to
ax_platform_node_auralinux_get_size, instead of creating a new method.
And similarly for GetExtents & GetPosition. 
Need feedback on this. 

[dmazzoni, 2015/03/31 15:13:48]

No, I prefer it this way. The C functions (ax_platform_node_auralinux_get_size)
should just be tiny wrappers that don't do any logic, they should just convert
types and then call a C++ function.

Thanks.

+  *width = rect_size.width();
+  *height = rect_size.height();
+}
+
+gfx::Rect AXPlatformNodeAuraLinux::GetWindowCoords() {
+  AtkObject* parent = GetParent();
+
+  ui::AXPlatformNodeAuraLinux* obj =
+      AtkObjectToAXPlatformNodeAuraLinux(parent);
+
+  if (atk_object_get_role(parent) == ATK_ROLE_WINDOW) {
+    gfx::Rect window_coords = obj->GetData().location;
+    return window_coords;
+  }
+
+  return obj->GetWindowCoords();
+}
+
 }  // namespace ui