Flag to clear data savings when Chrome starts up.

Flag to clear data savings when Chrome starts up.

Add a "clear-data-reduction-proxy-data-savings" flag, which when
enabled will clear out data savings statistics on startup.

BUG=461022
Committed: https://crrev.com/0cf4c5c1ad031c67b48d76cb599122be6f7e0709
Cr-Commit-Position: refs/heads/master@{#320936}

[Not at Google. Contact bengr, 2015-03-16 21:03:05]

kundaji@chromium.org changed reviewers:
+ bengr@chromium.org

[Not at Google. Contact bengr, 2015-03-16 21:03:29]

bengr: *

[bengr, 2015-03-16 22:54:17]

https://codereview.chromium.org/1010083002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1010083002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6536: +         Clear data savings on restart
Maybe "Clear data savings on startup"

https://codereview.chromium.org/1010083002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6539: +         Clears data saving obtained
by using data reduction proxy when chrome restarts.
Clears data savings obtained by using the data reduction proxy when Chrome
starts.

https://codereview.chromium.org/1010083002/diff/20001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc
(right):

https://codereview.chromium.org/1010083002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc:77:
list_pref_map_.get(data_reduction_proxy::prefs::
Please move this to a function called ClearStatistics, or something like that.
E.g.:

if (base::CommandLine::ForCurrentProcess()->HasSwitch(...))
  ClearStatistics();

[Not at Google. Contact bengr, 2015-03-16 23:25:28]

https://codereview.chromium.org/1010083002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1010083002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6536: +         Clear data savings on restart
On 2015/03/16 22:54:16, bengr wrote:
> Maybe "Clear data savings on startup"

Done.

https://codereview.chromium.org/1010083002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6539: +         Clears data saving obtained
by using data reduction proxy when chrome restarts.
On 2015/03/16 22:54:16, bengr wrote:
> Clears data savings obtained by using the data reduction proxy when Chrome
> starts.

Done.

https://codereview.chromium.org/1010083002/diff/20001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc
(right):

https://codereview.chromium.org/1010083002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc:77:
list_pref_map_.get(data_reduction_proxy::prefs::
On 2015/03/16 22:54:17, bengr wrote:
> Please move this to a function called ClearStatistics, or something like that.
> E.g.:
> 
> if (base::CommandLine::ForCurrentProcess()->HasSwitch(...))
>   ClearStatistics();
> 

Done.

[Not at Google. Contact bengr, 2015-03-16 23:27:47]

kundaji@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Not at Google. Contact bengr, 2015-03-16 23:28:18]

bengr:
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h

asvitkine:
  tools/metrics/histograms/histograms.xml

[bengr, 2015-03-16 23:33:59]

https://codereview.chromium.org/1010083002/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h
(right):

https://codereview.chromium.org/1010083002/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h:102:
void ClearDataSavingStatistics();
Please rearrange the ordering of methods so that they are in the same order in
the .h and the .cc.

[Not at Google. Contact bengr, 2015-03-16 23:45:56]

https://codereview.chromium.org/1010083002/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h
(right):

https://codereview.chromium.org/1010083002/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h:102:
void ClearDataSavingStatistics();
On 2015/03/16 23:33:59, bengr wrote:
> Please rearrange the ordering of methods so that they are in the same order in
> the .h and the .cc.

Done.

[bengr, 2015-03-16 23:53:14]

lgtm

[Alexei Svitkine (slow), 2015-03-17 00:54:41]

lgtm

[Not at Google. Contact bengr, 2015-03-17 16:39:26]

The CQ bit was checked by kundaji@chromium.org

[Not at Google. Contact bengr, 2015-03-17 16:39:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1010083002/#ps80001
(title: "Sync to head")

[commit-bot: I haz the power, 2015-03-17 16:39:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010083002/80001

[commit-bot: I haz the power, 2015-03-17 17:35:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-17 17:35:46]

Patchset 5 (id:??) landed as
https://crrev.com/0cf4c5c1ad031c67b48d76cb599122be6f7e0709
Cr-Commit-Position: refs/heads/master@{#320936}