Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/clang/scripts/run_tool.py

Issue 1010073002: clang: Add a tool for MessageLoop refactoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add warning to script. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/scripts/run_tool.py
diff --git a/tools/clang/scripts/run_tool.py b/tools/clang/scripts/run_tool.py
index 58a9a86570c6b3b203d5a0004ce56d04426db314..16c8cb32f5d76a6942370f4ef50a59bd8543b274 100755
--- a/tools/clang/scripts/run_tool.py
+++ b/tools/clang/scripts/run_tool.py
@@ -318,7 +318,7 @@ def main(argv):
else:
filenames = set(_GetFilesFromGit(argv[2:]))
# Filter out files that aren't C/C++/Obj-C/Obj-C++.
- extensions = frozenset(('.c', '.cc', '.m', '.mm'))
+ extensions = frozenset(('.c', '.cc', '.h', '.m', '.mm'))
dcheng 2015/05/06 17:31:18 Why does this need to change? There (should) never
Sami 2015/05/07 10:37:37 IIRC without this some .h files were never getting
Sami 2015/05/07 13:31:35 Yeah, turns out if I don't do this, none of the .h
filenames = [f for f in filenames
if os.path.splitext(f)[1] in extensions]
dispatcher = _CompilerDispatcher(argv[0], argv[1], filenames)

Powered by Google App Engine
This is Rietveld 408576698