[Webapp Refactor] Implements remoting.ConnectionInfo.

remoting/webapp/app_remoting/js/app_remoting.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * This class implements the functionality that is specific to application
  * remoting ("AppRemoting" or AR).
  */
 
@@ skipping 12 matching lines @@
 
   /** @private {remoting.ApplicationContextMenu} */
   this.contextMenu_ = null;
 
   /** @private {remoting.KeyboardLayoutsMenu} */
   this.keyboardLayoutsMenu_ = null;
 
   /** @private {remoting.WindowActivationMenu} */
   this.windowActivationMenu_ = null;
 
-   /** @private {number} */
-   this.pingTimerId_ = 0;
+   /** @private {base.RepeatingTimer} */

[garykac, 2015/03/16 20:43:33]

Nice!

+   this.pingTimer_ = null;
 };
 
 /**
  * Type definition for the RunApplicationResponse returned by the API.
  *
  * @constructor
  * @private
  */
 remoting.AppRemoting.AppHostResponse = function() {
   /** @type {string} */
@@ skipping 164 matching lines @@
   // shortcuts, but we want them to act as natively as possible.
   if (remoting.platformIsMac()) {
     return '0x0700e3>0x0700e0,0x0700e7>0x0700e4';
   }
   return '';
 };
 
 /**
  * Called when a new session has been connected.
  *
- * @param {remoting.ClientSession} clientSession
+ * @param {remoting.ConnectionInfo} connectionInfo
  * @return {void} Nothing.
  */
-remoting.AppRemoting.prototype.handleConnected = function(clientSession) {
+remoting.AppRemoting.prototype.handleConnected = function(connectionInfo) {
   remoting.identity.getUserInfo().then(
       function(userInfo) {
         remoting.clientSession.sendClientMessage(
             'setUserDisplayInfo',
             JSON.stringify({fullName: userInfo.name}));
       });
 
+  var clientSession = connectionInfo.session();
   // Set up a ping at 10-second intervals to test the connection speed.
-  function ping() {
+  this.pingTimer_ = new base.RepeatingTimer(function () {
     var message = { timestamp: new Date().getTime() };
     clientSession.sendClientMessage('pingRequest', JSON.stringify(message));
-  };
-  ping();
-  this.pingTimerId_ = window.setInterval(ping, 10 * 1000);
+  }, 10 * 1000);

[garykac, 2015/03/16 20:43:33]

Can we move this into a constant (with a descriptive comment)?

[kelvinp, 2015/03/16 21:00:21]

Done.

 };
 
 /**
  * Called when the current session has been disconnected.
  *
  * @return {void} Nothing.
  */
 remoting.AppRemoting.prototype.handleDisconnected = function() {
   // Cancel the ping when the connection closes.
-  window.clearInterval(this.pingTimerId_);
+  base.dispose(this.pingTimer_);
+  this.pingTimer_ = null;
 
   chrome.app.window.current().close();
 };
 
 /**
  * Called when the current session's connection has failed.
  *
  * @param {remoting.SessionConnector} connector
  * @param {!remoting.Error} error
  * @return {void} Nothing.
@@ skipping 81 matching lines @@
       chrome.i18n.getMessage(/*i18n-content*/'CONNECTION_FAILED'),
       chrome.i18n.getMessage(/** @type {string} */ (error.tag)));
 };
 
 /**
  * Close the loading window before exiting.
  */
 remoting.AppRemoting.prototype.handleExit = function() {
   remoting.LoadingWindow.close();
 };