[Webapp Refactor] Implements remoting.ConnectionInfo.

[Webapp Refactor] Implements remoting.ConnectionInfo.

This CL encapsulates various objects that maintain the state
of a remoting connection into a struct, remoting.ConnectionInfo.

This will prepares us for moving the creation logic of the
SessionConnector into the application delegates.

BUG=465878
Committed: https://crrev.com/0d9f28dcae36530c90f735a0a1c15be61fefe84e
Cr-Commit-Position: refs/heads/master@{#320820}

[kelvinp, 2015-03-16 19:59:28]

kelvinp@chromium.org changed reviewers:
+ garykac@chromium.org

[kelvinp, 2015-03-16 19:59:58]

PTAL

[garykac, 2015-03-16 20:43:33]

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/app_remoting.js (right):

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/app_remoting.js:33: /** @private
{base.RepeatingTimer} */
Nice!

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/app_remoting.js:235: }, 10 * 1000);
Can we move this into a constant (with a descriptive comment)?

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/crd/js/sess...
File remoting/webapp/crd/js/session_connector.js (right):

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/crd/js/sess...
remoting/webapp/crd/js/session_connector.js:156: remoting.ConnectionInfo =
function(host, credentialsProvider, session, plugin) {
I think that this would be better in a separate file since it's not a
SessionConnector.

[kelvinp, 2015-03-16 21:00:21]

PTAL

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/app_remoting.js (right):

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/app_remoting.js:235: }, 10 * 1000);
On 2015/03/16 20:43:33, garykac wrote:
> Can we move this into a constant (with a descriptive comment)?

Done.

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/crd/js/sess...
File remoting/webapp/crd/js/session_connector.js (right):

https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/crd/js/sess...
remoting/webapp/crd/js/session_connector.js:156: remoting.ConnectionInfo =
function(host, credentialsProvider, session, plugin) {
On 2015/03/16 20:43:33, garykac wrote:
> I think that this would be better in a separate file since it's not a
> SessionConnector.

Done.

[garykac, 2015-03-16 21:15:33]

lgtm

[kelvinp, 2015-03-16 21:19:52]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-03-16 21:20:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010053002/20001

[commit-bot: I haz the power, 2015-03-16 23:05:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-16 23:06:46]

Patchset 2 (id:??) landed as
https://crrev.com/0d9f28dcae36530c90f735a0a1c15be61fefe84e
Cr-Commit-Position: refs/heads/master@{#320820}