Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1010053002: [Webapp Refactor] Implements remoting.ConnectionInfo. (Closed)

Created:
5 years, 9 months ago by kelvinp
Modified:
5 years, 9 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Webapp Refactor] Implements remoting.ConnectionInfo. This CL encapsulates various objects that maintain the state of a remoting connection into a struct, remoting.ConnectionInfo. This will prepares us for moving the creation logic of the SessionConnector into the application delegates. BUG=465878 Committed: https://crrev.com/0d9f28dcae36530c90f735a0a1c15be61fefe84e Cr-Commit-Position: refs/heads/master@{#320820}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Reviewer's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -24 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting.js View 1 4 chunks +10 lines, -9 lines 0 comments Download
M remoting/webapp/base/js/application.js View 2 chunks +7 lines, -7 lines 0 comments Download
A remoting/webapp/crd/js/connection_info.js View 1 1 chunk +66 lines, -0 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/webapp/crd/js/session_connector.js View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/crd/js/session_connector_impl.js View 1 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kelvinp
PTAL
5 years, 9 months ago (2015-03-16 19:59:58 UTC) #2
garykac
https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js File remoting/webapp/app_remoting/js/app_remoting.js (right): https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js#newcode33 remoting/webapp/app_remoting/js/app_remoting.js:33: /** @private {base.RepeatingTimer} */ Nice! https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js#newcode235 remoting/webapp/app_remoting/js/app_remoting.js:235: }, 10 ...
5 years, 9 months ago (2015-03-16 20:43:33 UTC) #3
kelvinp
PTAL https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js File remoting/webapp/app_remoting/js/app_remoting.js (right): https://codereview.chromium.org/1010053002/diff/1/remoting/webapp/app_remoting/js/app_remoting.js#newcode235 remoting/webapp/app_remoting/js/app_remoting.js:235: }, 10 * 1000); On 2015/03/16 20:43:33, garykac ...
5 years, 9 months ago (2015-03-16 21:00:21 UTC) #4
garykac
lgtm
5 years, 9 months ago (2015-03-16 21:15:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010053002/20001
5 years, 9 months ago (2015-03-16 21:20:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 23:05:20 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 23:06:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d9f28dcae36530c90f735a0a1c15be61fefe84e
Cr-Commit-Position: refs/heads/master@{#320820}

Powered by Google App Engine
This is Rietveld 408576698