content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 1009993002: PlzNavigate: destroy the speculative RFH on renderer-initiated navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 1009993002: PlzNavigate: destroy the speculative RFH on renderer-initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index e5ce493262856eb2942f043ec63b5519c65a3894..4fc4e1a0c0ac484fc3c7cf0569340ee75b7a0ee1 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -790,6 +790,7 @@ TEST_F(NavigationControllerTest, LoadURL_NewPending) {

// After the beforeunload but before it commits, do a new navigation.

main_test_rfh()->PrepareForCommit();

const GURL kNewURL("http://see");

+ main_test_rfh()->SendRendererInitiatedNavigationRequest(kNewURL, true);

nasko 2015/03/16 18:48:37 I think this is already in Carlos' recent CL.

carlosk 2015/03/17 14:42:59 It is. Rebasing will sort it out.

main_test_rfh()->PrepareForCommit();

contents()->GetMainFrame()->SendNavigate(3, kNewURL);

« no previous file with comments | « no previous file | content/browser/frame_host/navigator_impl.cc » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')