Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1009973004: Fix up some issues introduced by https://codereview.chromium.org/1013773002/ (Closed)

Created:
5 years, 9 months ago by jvanverth1
Modified:
5 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix up some issues introduced by https://codereview.chromium.org/1013773002/ Need to check for zero-length gradients when using the new correction. Make sure we use the old text sizes for color emoji test in dftext GM. BUG=skia:3540 Committed: https://skia.googlesource.com/skia/+/d68a550ec890c3e3135ffa119621e17e55d58dd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M gm/dftext.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 3 chunks +26 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
5 years, 9 months ago (2015-03-16 19:32:04 UTC) #2
robertphillips
lgtm
5 years, 9 months ago (2015-03-16 19:39:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009973004/1
5 years, 9 months ago (2015-03-16 19:43:40 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 19:58:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d68a550ec890c3e3135ffa119621e17e55d58dd6

Powered by Google App Engine
This is Rietveld 408576698