chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm - Issue 1009953002: Integrate ManagePasswordsState into ManagePasswordsUIController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm

Issue 1009953002: Integrate ManagePasswordsState into ManagePasswordsUIController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed the comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller.mm ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm » ('j') | chrome/browser/ui/passwords/manage_passwords_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm

index 2d4e3123c0d7c756f4199d4a9292b687f5f75d42..c90e11c1009b142704eda9b1be8ec0ccd78eb839 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm

@@ -41,7 +41,6 @@ class ManagePasswordsBubbleManageViewControllerTest

ManagePasswordsControllerTest::SetUp();

delegate_.reset(

[[ManagePasswordsBubbleManageViewTestDelegate alloc] init]);

- ui_controller()->SetState(password_manager::ui::MANAGE_STATE);

}

ManagePasswordsBubbleManageViewTestDelegate* delegate() {

@@ -79,14 +78,14 @@ TEST_F(ManagePasswordsBubbleManageViewControllerTest,

TEST_F(ManagePasswordsBubbleManageViewControllerTest,

ShouldShowNoPasswordsWhenNoPasswordsExistForSite) {

- EXPECT_TRUE(model()->best_matches().empty());

+ EXPECT_TRUE(model()->local_credentials().empty());

EXPECT_EQ([NoPasswordsView class], [controller().contentView class]);

}

TEST_F(ManagePasswordsBubbleManageViewControllerTest,

ShouldShowAllPasswordItemsWhenPasswordsExistForSite) {

// Add a few password entries.

- autofill::ConstPasswordFormMap map;

+ autofill::PasswordFormMap map;

autofill::PasswordForm form1;

form1.username_value = base::ASCIIToUTF16("username1");

form1.password_value = base::ASCIIToUTF16("password1");

@@ -98,11 +97,11 @@ TEST_F(ManagePasswordsBubbleManageViewControllerTest,

map[base::ASCIIToUTF16("username2")] = &form2;

// Add the entries to the model.

- ui_controller()->SetPasswordFormMap(map);

+ ui_controller()->OnPasswordAutofilled(map);

model()->set_state(password_manager::ui::MANAGE_STATE);

// Check the view state.

- EXPECT_FALSE(model()->best_matches().empty());

+ EXPECT_FALSE(model()->local_credentials().empty());

EXPECT_EQ([PasswordItemListView class], [controller().contentView class]);

NSArray* items = base::mac::ObjCCastStrict<PasswordItemListView>(

controller().contentView).itemViews;