Integrate ManagePasswordsState into ManagePasswordsUIController.

chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index f01f7950b0bbad4367acff290fc299b184739efa..150d78eb25c2c7435cb716d343de4b151eb1a23a 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -95,16 +95,12 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
   const autofill::PasswordForm& pending_password() const {
     return pending_password_;
   }
-  const autofill::ConstPasswordFormMap& best_matches() const {
-    return best_matches_;
+  const ScopedVector<const autofill::PasswordForm>& local_credentials() const {

[groby-ooo-7-16, 2015/03/16 22:03:17]

Please add a comment what "local_credentials" and "federated_credentials" are -
I'm not sure I follow why it's OK to fold best_matches_ into local_credentials_

[vasilii, 2015/03/17 10:49:48]

Done.

+    return local_credentials_;
   }
-  const ScopedVector<autofill::PasswordForm>& local_pending_credentials()
+  const ScopedVector<const autofill::PasswordForm>& federated_credentials()
       const {
-    return local_pending_credentials_;
-  }
-  const ScopedVector<autofill::PasswordForm>& federated_pending_credentials()
-      const {
-    return federated_pending_credentials_;
+    return federated_credentials_;
   }
   const base::string16& manage_link() const { return manage_link_; }
   bool never_save_passwords() const { return never_save_passwords_; }
@@ -133,7 +129,7 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
   void set_state(password_manager::ui::State state) { state_ = state; }
 #endif
 
-// Upper limits on the size of the username and password fields.
+  // Upper limits on the size of the username and password fields.
   static int UsernameFieldWidth();
   static int PasswordFieldWidth();
 
@@ -143,9 +139,8 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
   password_manager::ui::State state_;
   base::string16 title_;
   autofill::PasswordForm pending_password_;
-  autofill::ConstPasswordFormMap best_matches_;
-  ScopedVector<autofill::PasswordForm> local_pending_credentials_;
-  ScopedVector<autofill::PasswordForm> federated_pending_credentials_;
+  ScopedVector<const autofill::PasswordForm> local_credentials_;
+  ScopedVector<const autofill::PasswordForm> federated_credentials_;
   base::string16 manage_link_;
   base::string16 save_confirmation_text_;
   gfx::Range save_confirmation_link_range_;