chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc - Issue 1009953002: Integrate ManagePasswordsState into ManagePasswordsUIController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc

Issue 1009953002: Integrate ManagePasswordsState into ManagePasswordsUIController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/account_chooser_infobar_delegate_android.h ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm » ('j') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc

diff --git a/chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc b/chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc

index 21a252e2b25c5bb13537b96f08add3ac7e17d2dd..a4654ffc371e5634d167f474f804a981eb5fc363 100644

--- a/chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc

+++ b/chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc

@@ -36,10 +36,10 @@ void AccountChooserInfoBarDelegateAndroid::ChooseCredential(

}

DCHECK(credential_type == CredentialType::CREDENTIAL_TYPE_LOCAL ||

credential_type == CredentialType::CREDENTIAL_TYPE_FEDERATED);

- auto& credentials_forms =

+ const auto& credentials_forms =

(credential_type == CredentialType::CREDENTIAL_TYPE_LOCAL)

- ? ui_controller_->local_credentials_forms()

- : ui_controller_->federated_credentials_forms();

+ ? ui_controller_->GetCurrentForms()

+ : ui_controller_->GetFederatedForms();

if (credential_index < credentials_forms.size()) {

ui_controller_->ChooseCredential(*credentials_forms[credential_index],

credential_type);